Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88bac9ca authored by Anna Zappone's avatar Anna Zappone
Browse files

Add available description for talkback 

Bug: 189908609
Test: PeopleTileViewHelperTest and local
Change-Id: I5b00dfdb8aa04b84aa71d37adfbd06f134bcf5a9
parent 50c03ea7

packages/SystemUI/res/values/strings.xml

+2 −0
Original line number Diff line number Diff line
@@ -2956,6 +2956,8 @@ 
    <string name="new_notification_image_content_description"><xliff:g id="name" example="Anna">%1$s</xliff:g> sent an image</string>

    <!-- Content description text on the Conversation widget when a person has a new status posted [CHAR LIMIT=150] -->

    <string name="new_status_content_description"><xliff:g id="name" example="Anna">%1$s</xliff:g> has a status update: <xliff:g id="status" example="Listening to music">%2$s</xliff:g></string>

    <!-- Content description text on the Conversation widget when a person is  available, meaning online on an application [CHAR LIMIT=150] -->

    <string name="person_available">Available</string>



    <!-- Title to display in a notification when ACTION_BATTERY_CHANGED.EXTRA_PRESENT field is false

    [CHAR LIMIT=NONE] -->

packages/SystemUI/src/com/android/systemui/people/PeopleTileViewHelper.java

+2 −0
Original line number Diff line number Diff line
@@ -501,6 +501,8 @@ public class PeopleTileViewHelper { 
                views.setViewVisibility(R.id.availability, View.VISIBLE);

                startPadding = mContext.getResources().getDimensionPixelSize(

                        R.dimen.availability_dot_shown_padding);

                views.setContentDescription(R.id.availability,

                        mContext.getString(R.string.person_available));

            } else {

                views.setViewVisibility(R.id.availability, View.GONE);

                startPadding = mContext.getResources().getDimensionPixelSize(

packages/SystemUI/tests/src/com/android/systemui/people/PeopleTileViewHelperTest.java

+4 −0
Original line number Diff line number Diff line
@@ -289,6 +289,8 @@ public class PeopleTileViewHelperTest extends SysuiTestCase { 
        assertEquals(View.GONE, result.findViewById(R.id.last_interaction).getVisibility());

        // Has availability.

        assertEquals(View.VISIBLE, result.findViewById(R.id.availability).getVisibility());

        assertEquals(result.findViewById(R.id.availability).getContentDescription(),

                mContext.getString(R.string.person_available));

        // Has person icon.

        assertEquals(View.VISIBLE, result.findViewById(R.id.person_icon).getVisibility());

        // No status.
@@ -334,6 +336,8 @@ public class PeopleTileViewHelperTest extends SysuiTestCase { 
        assertEquals(View.GONE, largeResult.findViewById(R.id.last_interaction).getVisibility());

        // Has availability.

        assertEquals(View.VISIBLE, largeResult.findViewById(R.id.availability).getVisibility());

        assertEquals(largeResult.findViewById(R.id.availability).getContentDescription(),

                mContext.getString(R.string.person_available));

        // Shows person icon.

        assertEquals(View.VISIBLE, largeResult.findViewById(R.id.person_icon).getVisibility());

        // No status.