Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88b09db1 authored by Jeff DeCew's avatar Jeff DeCew
Browse files

Rewrite dumping NSSL hierarchy 

* Adds DumpUtils which make it easier to efficiently build nested dumps
* Adds a function to dump visibility to a string

Fixes: 204583447
Test: perform dump, read output
Change-Id: I1af2cff8a2add555e9190f719150586780b55c18
parent a9efae98

packages/SystemUI/src/com/android/systemui/statusbar/notification/row/ExpandableNotificationRow.java

+40 −34
Original line number Diff line number Diff line
@@ -107,6 +107,7 @@ import com.android.systemui.statusbar.phone.KeyguardBypassController; 
import com.android.systemui.statusbar.phone.StatusBar;

import com.android.systemui.statusbar.policy.HeadsUpManager;

import com.android.systemui.statusbar.policy.InflatedSmartReplyState;

import com.android.systemui.util.DumpUtilsKt;

import com.android.systemui.wmshell.BubblesManager;



import java.io.FileDescriptor;
@@ -3311,40 +3312,45 @@ public class ExpandableNotificationRow extends ActivatableNotificationView 


    @Override

    public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {

        super.dump(fd, pw, args);

        // Skip super call; dump viewState ourselves

        pw.println("Notification: " + mEntry.getKey());

        pw.print("    visibility: " + getVisibility());

        pw.print(", alpha: " + getAlpha());

        pw.print(", translation: " + getTranslation());

        pw.print(", removed: " + isRemoved());

        pw.print(", expandAnimationRunning: " + mExpandAnimationRunning);

        DumpUtilsKt.withIndenting(pw, ipw -> {

            ipw.print("visibility: " + getVisibility());

            ipw.print(", alpha: " + getAlpha());

            ipw.print(", translation: " + getTranslation());

            ipw.print(", removed: " + isRemoved());

            ipw.print(", expandAnimationRunning: " + mExpandAnimationRunning);

            NotificationContentView showingLayout = getShowingLayout();

        pw.print(", privateShowing: " + (showingLayout == mPrivateLayout));

        pw.println();

        showingLayout.dump(fd, pw, args);

        pw.print("    ");

            ipw.print(", privateShowing: " + (showingLayout == mPrivateLayout));

            ipw.println();

            showingLayout.dump(fd, ipw, args);



            if (getViewState() != null) {

            getViewState().dump(fd, pw, args);

                getViewState().dump(fd, ipw, args);

                ipw.println();

            } else {

            pw.print("no viewState!!!");

                ipw.println("no viewState!!!");

            }

        pw.println();

        pw.println();



            if (mIsSummaryWithChildren) {

            pw.print("  ChildrenContainer");

            pw.print(" visibility: " + mChildrenContainer.getVisibility());

            pw.print(", alpha: " + mChildrenContainer.getAlpha());

            pw.print(", translationY: " + mChildrenContainer.getTranslationY());

            pw.println();

                ipw.println();

                ipw.print("ChildrenContainer");

                ipw.print(" visibility: " + mChildrenContainer.getVisibility());

                ipw.print(", alpha: " + mChildrenContainer.getAlpha());

                ipw.print(", translationY: " + mChildrenContainer.getTranslationY());

                ipw.println();

                List<ExpandableNotificationRow> notificationChildren = getAttachedChildren();

            pw.println("  Children: " + notificationChildren.size());

            pw.println("  {");

                ipw.println("Children: " + notificationChildren.size());

                ipw.print("{");

                ipw.increaseIndent();

                for (ExpandableNotificationRow child : notificationChildren) {

                child.dump(fd, pw, args);

                    ipw.println();

                    child.dump(fd, ipw, args);

                }

            pw.println("  }");

            pw.println();

                ipw.decreaseIndent();

                ipw.println("}");

            }

        });

    }



    /**

packages/SystemUI/src/com/android/systemui/statusbar/notification/row/ExpandableView.java

+11 −0
Original line number Diff line number Diff line
@@ -34,6 +34,7 @@ import com.android.systemui.animation.Interpolators; 
import com.android.systemui.statusbar.StatusBarIconView;

import com.android.systemui.statusbar.notification.stack.ExpandableViewState;

import com.android.systemui.statusbar.notification.stack.NotificationStackScrollLayout;

import com.android.systemui.util.DumpUtilsKt;



import java.io.FileDescriptor;

import java.io.PrintWriter;
@@ -743,6 +744,16 @@ public abstract class ExpandableView extends FrameLayout implements Dumpable { 


    @Override

    public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {

        pw.println(getClass().getSimpleName());

        DumpUtilsKt.withIndenting(pw, ipw -> {

            ExpandableViewState viewState = getViewState();

            if (viewState == null) {

                ipw.println("no viewState!!!");

            } else {

                viewState.dump(fd, ipw, args);

                ipw.println();

            }

        });

    }



    /**

packages/SystemUI/src/com/android/systemui/statusbar/notification/row/FooterView.java

+17 −0
Original line number Diff line number Diff line
@@ -25,6 +25,10 @@ import android.view.View; 
import com.android.systemui.R;

import com.android.systemui.statusbar.notification.stack.ExpandableViewState;

import com.android.systemui.statusbar.notification.stack.ViewState;

import com.android.systemui.util.DumpUtilsKt;



import java.io.FileDescriptor;

import java.io.PrintWriter;



public class FooterView extends StackScrollerDecorView {

    private FooterViewButton mDismissButton;
@@ -44,6 +48,19 @@ public class FooterView extends StackScrollerDecorView { 
        return findViewById(R.id.dismiss_text);

    }



    @Override

    public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {

        super.dump(fd, pw, args);

        DumpUtilsKt.withIndenting(pw, ipw -> {

            ipw.println("visibility: " + DumpUtilsKt.visibilityString(getVisibility()));

            ipw.println("manageButton showHistory: " + mShowHistory);

            ipw.println("manageButton visibility: "

                    + DumpUtilsKt.visibilityString(mDismissButton.getVisibility()));

            ipw.println("dismissButton visibility: "

                    + DumpUtilsKt.visibilityString(mDismissButton.getVisibility()));

        });

    }



    @Override

    protected void onFinishInflate() {

        super.onFinishInflate();

packages/SystemUI/src/com/android/systemui/statusbar/notification/row/NotificationContentView.java

+0 −1
Original line number Diff line number Diff line
@@ -1938,7 +1938,6 @@ public class NotificationContentView extends FrameLayout { 
    }



    public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {

        pw.print("    ");

        pw.print("contentView visibility: " + getVisibility());

        pw.print(", alpha: " + getAlpha());

        pw.print(", clipBounds: " + getClipBounds());

packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLayout.java

+35 −46
Original line number Diff line number Diff line
@@ -109,6 +109,7 @@ import com.android.systemui.statusbar.phone.UnlockedScreenOffAnimationController 
import com.android.systemui.statusbar.policy.HeadsUpUtil;

import com.android.systemui.statusbar.policy.ScrollAdapter;

import com.android.systemui.util.Assert;

import com.android.systemui.util.DumpUtilsKt;



import java.io.FileDescriptor;

import java.io.PrintWriter;
@@ -4911,41 +4912,28 @@ public class NotificationStackScrollLayout extends ViewGroup implements Dumpable 


    @ShadeViewRefactor(RefactorComponent.SHADE_VIEW)

    public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {

        pw.println(String.format("[%s: pulsing=%s visibility=%s"

                        + " alpha=%f scrollY:%d maxTopPadding=%d showShelfOnly=%s"

                        + " qsExpandFraction=%f"

                        + " hideAmount=%f]",

                this.getClass().getSimpleName(),

                mPulsing ? "T" : "f",

                getVisibility() == View.VISIBLE ? "visible"

                        : getVisibility() == View.GONE ? "gone"

                                : "invisible",

                getAlpha(),

                mAmbientState.getScrollY(),

                mMaxTopPadding,

                mShouldShowShelfOnly ? "T" : "f",

                mQsExpansionFraction,

                mAmbientState.getHideAmount()));

        StringBuilder sb = new StringBuilder("[")

                .append(this.getClass().getSimpleName()).append(":")

                .append(" pulsing=").append(mPulsing ? "T" : "f")

                .append(" visibility=").append(DumpUtilsKt.visibilityString(getVisibility()))

                .append(" alpha=").append(getAlpha())

                .append(" scrollY=").append(mAmbientState.getScrollY())

                .append(" maxTopPadding=").append(mMaxTopPadding)

                .append(" showShelfOnly=").append(mShouldShowShelfOnly ? "T" : "f")

                .append(" qsExpandFraction=").append(mQsExpansionFraction)

                .append(" isCurrentUserSetup=").append(mIsCurrentUserSetup)

                .append(" hideAmount=").append(mAmbientState.getHideAmount())

                .append("]");

        pw.println(sb.toString());

        DumpUtilsKt.withIndenting(pw, ipw -> {

            int childCount = getChildCount();

        pw.println("  Number of children: " + childCount);

        pw.println();

            ipw.println("Number of children: " + childCount);

            ipw.println();



            for (int i = 0; i < childCount; i++) {

                ExpandableView child = (ExpandableView) getChildAt(i);

            child.dump(fd, pw, args);

            if (!(child instanceof ExpandableNotificationRow)) {

                pw.println("  " + child.getClass().getSimpleName());

                // Notifications dump it's viewstate as part of their dump to support children

                ExpandableViewState viewState = child.getViewState();

                if (viewState == null) {

                    pw.println("    no viewState!!!");

                } else {

                    pw.print("    ");

                    viewState.dump(fd, pw, args);

                    pw.println();

                    pw.println();

                }

            }

                child.dump(fd, ipw, args);

                ipw.println();

            }

            int transientViewCount = getTransientViewCount();

            pw.println("Transient Views: " + transientViewCount);
@@ -4959,6 +4947,7 @@ public class NotificationStackScrollLayout extends ViewGroup implements Dumpable 
                ExpandableView expandableView = (ExpandableView) swipedView;

                expandableView.dump(fd, pw, args);

            }

        });

    }



    @ShadeViewRefactor(RefactorComponent.SHADE_VIEW)