Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88839c0e authored by Matías Hernández's avatar Matías Hernández
Browse files

Fix one of the strict-zen-validation tests 

Updating an existing AZR's CPS is always ignored, so the case we were trying to test never actually happened. Modified and renamed the test to verify the actual expected behavior (and made it non-flag dependent since the flag doesn't affect this particular part).

Bug: 420605963
Test: atest android.app.NotificationManagerZenTest
Flag: TEST_ONLY
Change-Id: Ie89248ada680611310c2405c0805b7f3c8dfc50d
parent 8286994c

services/tests/uiservicestests/src/android/app/NotificationManagerZenTest.java

+3 −3
Original line number Diff line number Diff line
@@ -244,8 +244,7 @@ public class NotificationManagerZenTest { 
    }



    @Test

    @RequiresFlagsEnabled(FLAG_STRICT_ZEN_RULE_COMPONENT_VALIDATION)

    public void updateAutomaticZenRule_switchToInvalidCpsButWithValidConfigActivity_cpsGone() {

    public void updateAutomaticZenRule_switchToInvalidCpsButWithValidConfigActivity_cpsReverts() {

        AutomaticZenRule original = new AutomaticZenRule.Builder("OK so far", CONDITION_ID)

                .setOwner(CONDITION_PROVIDER_SERVICE)

                .setConfigurationActivity(CONFIGURATION_ACTIVITY)
@@ -257,9 +256,10 @@ public class NotificationManagerZenTest { 
                .build();

        mNotificationManager.updateAutomaticZenRule(ruleId, sneaky);



        // Unlike for configurationActivity, an app cannot modify the CPS associated to an AZR.

        AutomaticZenRule savedAzr = mNotificationManager.getAutomaticZenRule(ruleId);

        assertThat(savedAzr).isNotNull();

        assertThat(savedAzr.getOwner()).isNull();

        assertThat(savedAzr.getOwner()).isEqualTo(CONDITION_PROVIDER_SERVICE);

        assertThat(savedAzr.getConfigurationActivity()).isEqualTo(CONFIGURATION_ACTIVITY);

    }