Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 87ef2a02 authored by Fabián Kozynski's avatar Fabián Kozynski
Browse files

Extract QSHost.newInstanceId 

Combine it with a UiEventLogger in a QsEventLogger to feed to tiles.

Also, remove QSHost.warn as it was not being used for anything.

Test: atest com.android.systemui.qs
Fixes: 277240050
Change-Id: I6b94014974d0865133c6b8de16fb35ddf04a431b
parent 346a9f61

packages/SystemUI/src/com/android/systemui/qs/QSHost.java

+0 −4
Original line number Diff line number Diff line
@@ -20,7 +20,6 @@ import android.content.res.Resources; 
import android.os.Build;

import android.provider.Settings;



import com.android.internal.logging.InstanceId;

import com.android.systemui.R;

import com.android.systemui.plugins.qs.QSFactory;

import com.android.systemui.plugins.qs.QSTile;
@@ -54,7 +53,6 @@ public interface QSHost { 
        return tiles;

    }



    void warn(String message, Throwable t);

    Context getContext();

    Context getUserContext();

    int getUserId();
@@ -105,8 +103,6 @@ public interface QSHost { 


    int indexOf(String tileSpec);



    InstanceId getNewInstanceId();



    interface Callback {

        void onTilesChanged();

    }

packages/SystemUI/src/com/android/systemui/qs/QSHostAdapter.kt

+1 −10
Original line number Diff line number Diff line
@@ -19,7 +19,6 @@ package com.android.systemui.qs 
import android.content.ComponentName

import android.content.Context

import androidx.annotation.GuardedBy

import com.android.internal.logging.InstanceId

import com.android.systemui.dagger.SysUISingleton

import com.android.systemui.dagger.qualifiers.Application

import com.android.systemui.dump.DumpManager
@@ -40,7 +39,7 @@ import kotlinx.coroutines.launch 
 * Adapter to determine what real class to use for classes that depend on [QSHost].

 * * When [Flags.QS_PIPELINE_NEW_HOST] is off, all calls will be routed to [QSTileHost].

 * * When [Flags.QS_PIPELINE_NEW_HOST] is on, calls regarding the current set of tiles will be

 *   routed to [CurrentTilesInteractor]. Other calls (like [warn]) will still be routed to

 *   routed to [CurrentTilesInteractor]. Other calls (like [createTileView]) will still be routed to

 *   [QSTileHost].

 *

 * This routing also includes dumps.
@@ -153,10 +152,6 @@ constructor( 
        }

    }



    override fun warn(message: String?, t: Throwable?) {

        qsTileHost.warn(message, t)

    }



    override fun getContext(): Context {

        return if (useNewHost) {

            context
@@ -204,8 +199,4 @@ constructor( 
    override fun indexOf(tileSpec: String): Int {

        return specs.indexOf(tileSpec)

    }



    override fun getNewInstanceId(): InstanceId {

        return qsTileHost.newInstanceId

    }

}

packages/SystemUI/src/com/android/systemui/qs/QSTileHost.java

+0 −16
Original line number Diff line number Diff line
@@ -29,9 +29,6 @@ import androidx.annotation.MainThread; 
import androidx.annotation.Nullable;



import com.android.internal.annotations.VisibleForTesting;

import com.android.internal.logging.InstanceId;

import com.android.internal.logging.InstanceIdSequence;

import com.android.internal.logging.UiEventLogger;

import com.android.systemui.Dumpable;

import com.android.systemui.ProtoDumpable;

import com.android.systemui.R;
@@ -91,7 +88,6 @@ public class QSTileHost implements QSHost, Tunable, PluginListener<QSFactory>, P 
        PanelInteractor, CustomTileAddedRepository {

    private static final String TAG = "QSTileHost";

    private static final boolean DEBUG = Log.isLoggable(TAG, Log.DEBUG);

    private static final int MAX_QS_INSTANCE_ID = 1 << 20;



    // Shared prefs that hold tile lifecycle info.

    @VisibleForTesting
@@ -103,7 +99,6 @@ public class QSTileHost implements QSHost, Tunable, PluginListener<QSFactory>, P 
    private final TunerService mTunerService;

    private final PluginManager mPluginManager;

    private final QSLogger mQSLogger;

    private final InstanceIdSequence mInstanceIdSequence;

    private final CustomTileStatePersister mCustomTileStatePersister;

    private final Executor mMainExecutor;

    private final UserFileManager mUserFileManager;
@@ -153,7 +148,6 @@ public class QSTileHost implements QSHost, Tunable, PluginListener<QSFactory>, P 
        mUserFileManager = userFileManager;

        mFeatureFlags = featureFlags;



        mInstanceIdSequence = new InstanceIdSequence(MAX_QS_INSTANCE_ID);

        mCentralSurfacesOptional = centralSurfacesOptional;



        mQsFactories.add(defaultFactory);
@@ -172,11 +166,6 @@ public class QSTileHost implements QSHost, Tunable, PluginListener<QSFactory>, P 
        });

    }



    @Override

    public InstanceId getNewInstanceId() {

        return mInstanceIdSequence.newInstanceId();

    }



    public void destroy() {

        mTiles.values().forEach(tile -> tile.destroy());

        mAutoTiles.destroy();
@@ -218,11 +207,6 @@ public class QSTileHost implements QSHost, Tunable, PluginListener<QSFactory>, P 
        return mTiles.values();

    }



    @Override

    public void warn(String message, Throwable t) {

        // already logged

    }



    @Override

    public void collapsePanels() {

        mCentralSurfacesOptional.ifPresent(CentralSurfaces::postAnimateCollapsePanels);

packages/SystemUI/src/com/android/systemui/qs/QsEventLogger.kt

0 → 100644
+44 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2023 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *     http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



package com.android.systemui.qs



import com.android.internal.logging.InstanceId

import com.android.internal.logging.InstanceIdSequence

import com.android.internal.logging.UiEventLogger

import com.android.systemui.dagger.SysUISingleton

import javax.inject.Inject



interface QsEventLogger : UiEventLogger {

    fun getNewInstanceId(): InstanceId

}



@SysUISingleton

class QsEventLoggerImpl

@Inject

constructor(

    uiEventLogger: UiEventLogger,

) : QsEventLogger, UiEventLogger by uiEventLogger {



    companion object {

        private const val MAX_QS_INSTANCE_ID = 1 shl 20

    }



    val sequence = InstanceIdSequence(MAX_QS_INSTANCE_ID)

    override fun getNewInstanceId(): InstanceId {

        return sequence.newInstanceId()

    }

}

packages/SystemUI/src/com/android/systemui/qs/dagger/QSHostModule.kt

+6 −0
Original line number Diff line number Diff line
@@ -21,6 +21,8 @@ import com.android.systemui.flags.Flags 
import com.android.systemui.qs.QSHost

import com.android.systemui.qs.QSHostAdapter

import com.android.systemui.qs.QSTileHost

import com.android.systemui.qs.QsEventLogger

import com.android.systemui.qs.QsEventLoggerImpl

import com.android.systemui.qs.pipeline.data.repository.CustomTileAddedRepository

import com.android.systemui.qs.pipeline.data.repository.CustomTileAddedSharedPrefsRepository

import com.android.systemui.qs.pipeline.domain.interactor.PanelInteractor
@@ -34,8 +36,12 @@ interface QSHostModule { 


    @Binds fun provideQsHost(controllerImpl: QSHostAdapter): QSHost



    @Binds fun provideEventLogger(impl: QsEventLoggerImpl): QsEventLogger



    @Module

    companion object {

        private const val MAX_QS_INSTANCE_ID = 1 shl 20



        @Provides

        @JvmStatic

        fun providePanelInteractor(