Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8770248f authored by Daichi Hirono's avatar Daichi Hirono
Browse files

Change deleteRootTasks so that it returns false instead of exception 

Before the CL deleteRootTasks throws a RuntimeException when a specified
task has already been GCed. Callers of this API don't have a way of
guaranteeing the existance of task in the system server process, so they
need to catch the excpetions always, which resulted in hiding other
RuntimeException potentially caused by programming errors.

Because missing tasks is not a programming error, this CL changes the
exception to a false return value.

Bug: 179324112
Test: None
Change-Id: I335c43954d467a6bc99c2c958c54a76a48fd2ac9
parent e040263f

services/core/java/com/android/server/wm/TaskOrganizerController.java

+1 −3
Original line number Diff line number Diff line
@@ -596,9 +596,7 @@ class TaskOrganizerController extends ITaskOrganizerController.Stub { 
        try {

            synchronized (mGlobalLock) {

                final WindowContainer wc = WindowContainer.fromBinder(token.asBinder());

                if (wc == null) {

                    throw new IllegalArgumentException("Can't resolve window from token");

                }

                if (wc == null) return false;

                final Task task = wc.asTask();

                if (task == null) return false;

                if (!task.mCreatedByOrganizer) {