Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8753d824 authored by Oli Lan's avatar Oli Lan
Browse files

Check DUMP permission before dumping in RollbackManagerService. 

Bug: 143125031
Test: atest CtsSecurityTestCases:android.security.cts.ServicePermissionsTest#testDumpProtected
Change-Id: Icd813d30eabc6d52a34bd3440a73d2e0876a89ed
parent 2e2d9842

services/core/java/com/android/server/rollback/RollbackManagerServiceImpl.java

+3 −0
Original line number Diff line number Diff line
@@ -53,6 +53,7 @@ import android.util.Slog; 
import android.util.SparseBooleanArray;



import com.android.internal.annotations.GuardedBy;

import com.android.internal.util.DumpUtils;

import com.android.internal.util.IndentingPrintWriter;

import com.android.server.LocalServices;

import com.android.server.Watchdog;
@@ -1133,6 +1134,8 @@ class RollbackManagerServiceImpl extends IRollbackManager.Stub { 


    @Override

    protected void dump(FileDescriptor fd, PrintWriter pw, String[] args) {

        if (!DumpUtils.checkDumpPermission(mContext, TAG, pw)) return;



        IndentingPrintWriter ipw = new IndentingPrintWriter(pw, "  ");

        synchronized (mLock) {

            for (Rollback rollback : mRollbacks) {