Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 874718f0 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Remove TODO in statsd AnomalyTracker_test"

parents 91afbbcf d27ab45a

cmds/statsd/tests/anomaly/AnomalyTracker_test.cpp

+8 −8
Original line number Diff line number Diff line
@@ -305,10 +305,10 @@ TEST(AnomalyTrackerTest, TestSparseBuckets) { 
    EXPECT_EQ(anomalyTracker.getSumOverPastBuckets(keyB), 2LL);

    EXPECT_EQ(anomalyTracker.getSumOverPastBuckets(keyC), 1LL);

    EXPECT_TRUE(detectAnomaliesPass(anomalyTracker, 16, bucket16, {keyB}, {keyA, keyC, keyD}));

    // TODO: after detectAnomaly fix: EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    EXPECT_EQ(anomalyTracker.mMostRecentBucketNum, 15L);

    detectAndDeclareAnomalies(anomalyTracker, 16, bucket16, eventTimestamp2);

    // TODO: after detectAnomaly fix: EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    EXPECT_EQ(anomalyTracker.mMostRecentBucketNum, 15L);

    checkRefractoryTimes(anomalyTracker, eventTimestamp2, refractoryPeriodSec,

            {{keyA, -1}, {keyB, eventTimestamp2}, {keyC, -1}, {keyD, -1}, {keyE, -1}});
@@ -366,7 +366,7 @@ TEST(AnomalyTrackerTest, TestSparseBuckets) { 
    EXPECT_EQ(anomalyTracker.getSumOverPastBuckets(keyC), 1LL);

    EXPECT_TRUE(detectAnomaliesPass(anomalyTracker, 25, bucket25, {}, {keyA, keyB, keyC, keyD}));

    EXPECT_EQ(anomalyTracker.mMostRecentBucketNum, 24L);

    // TODO: after detectAnomaly fix: EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    detectAndDeclareAnomalies(anomalyTracker, 25, bucket25, eventTimestamp5);

    checkRefractoryTimes(anomalyTracker, eventTimestamp5, refractoryPeriodSec,

            {{keyA, -1}, {keyB, eventTimestamp4}, {keyC, -1}, {keyD, -1}, {keyE, -1}});
@@ -374,14 +374,14 @@ TEST(AnomalyTrackerTest, TestSparseBuckets) { 
    // Add past bucket #25

    anomalyTracker.addPastBucket(bucket25, 25);

    EXPECT_EQ(anomalyTracker.mMostRecentBucketNum, 25L);

    // TODO: after detectAnomaly fix: EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 1UL);

    EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 1UL);

    EXPECT_EQ(anomalyTracker.getSumOverPastBuckets(keyD), 1LL);

    EXPECT_TRUE(detectAnomaliesPass(anomalyTracker, 28, bucket28, {},

            {keyA, keyB, keyC, keyD, keyE}));

    EXPECT_EQ(anomalyTracker.mMostRecentBucketNum, 27L);

    // TODO: after detectAnomaly fix: EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    detectAndDeclareAnomalies(anomalyTracker, 28, bucket28, eventTimestamp6);

    // TODO: after detectAnomaly fix: EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    checkRefractoryTimes(anomalyTracker, eventTimestamp6, refractoryPeriodSec,

            {{keyA, -1}, {keyB, -1}, {keyC, -1}, {keyD, -1}, {keyE, -1}});
@@ -390,9 +390,9 @@ TEST(AnomalyTrackerTest, TestSparseBuckets) { 
    EXPECT_TRUE(detectAnomaliesPass(anomalyTracker, 28, bucket28, {keyE},

            {keyA, keyB, keyC, keyD}));

    EXPECT_EQ(anomalyTracker.mMostRecentBucketNum, 27L);

    // TODO: after detectAnomaly fix: EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    detectAndDeclareAnomalies(anomalyTracker, 28, bucket28, eventTimestamp6 + 7);

    // TODO: after detectAnomaly fix: EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    EXPECT_EQ(anomalyTracker.mSumOverPastBuckets.size(), 0UL);

    checkRefractoryTimes(anomalyTracker, eventTimestamp6, refractoryPeriodSec,

            {{keyA, -1}, {keyB, -1}, {keyC, -1}, {keyD, -1}, {keyE, eventTimestamp6 + 7}});

}