Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 873e1938 authored by Fabian Kozynski's avatar Fabian Kozynski
Browse files

Fixed NPE when passing intent to permissioncontroller 

OngoingPrivacyDialog only assigns clickListeners to lines with a valid
package name.

Test: manual, Device Services is not clickable
Bug: 123581716
Change-Id: I7775cc39b7446fc93c53cbf0c70b9214e406cd74
parent 2d10bd04

packages/SystemUI/src/com/android/systemui/privacy/OngoingPrivacyDialog.kt

+16 −10
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ import android.app.Dialog 
import android.content.Context

import android.content.DialogInterface

import android.content.Intent

import android.content.pm.PackageManager

import android.content.res.ColorStateList

import android.os.UserHandle

import android.util.IconDrawableFactory
@@ -157,6 +158,9 @@ class OngoingPrivacyDialog constructor( 
        } else {

            icons.visibility = View.GONE

        }

        try {

            // Check if package exists

            context.packageManager.getPackageInfo(app.packageName, 0)

            item.setOnClickListener(object : View.OnClickListener {

                val intent = Intent(Intent.ACTION_REVIEW_APP_PERMISSION_USAGE)

                        .putExtra(Intent.EXTRA_PACKAGE_NAME, app.packageName)
@@ -167,6 +171,8 @@ class OngoingPrivacyDialog constructor( 
                    dismissDialog?.invoke()

                }

            })

        } catch (e: PackageManager.NameNotFoundException) {}



        itemList.addView(item)

    }

}