Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 87293fda authored by Chavi Weingarten's avatar Chavi Weingarten Committed by Android (Google) Code Review
Browse files

Merge "Fix Display SurfaceControl leak" into rvc-dev

parents 086e11fd b9c44aae

services/core/java/com/android/server/wm/DisplayContent.java

+3 −0
Original line number Original line Diff line number Diff line
@@ -2712,6 +2712,9 @@ class DisplayContent extends WindowContainer<DisplayContent.DisplayChildWindowCo 
            mRemovingDisplay = false;

            mRemovingDisplay = false;

        }

        }





        // Apply the pending transaction here since we may not be able to reach the DisplayContent

        // on the next traversal if it's removed from RootWindowContainer child list.

        getPendingTransaction().apply();

        mWmService.mWindowPlacerLocked.requestTraversal();

        mWmService.mWindowPlacerLocked.requestTraversal();

    }

    }

services/core/java/com/android/server/wm/WindowContainer.java

+0 −7
Original line number Original line Diff line number Diff line
@@ -524,13 +524,6 @@ class WindowContainer<E extends WindowContainer> extends ConfigurationContainer< 




        if (mSurfaceControl != null) {

        if (mSurfaceControl != null) {

            getPendingTransaction().remove(mSurfaceControl);

            getPendingTransaction().remove(mSurfaceControl);



            // Merge to parent transaction to ensure the transactions on this WindowContainer are

            // applied in native even if WindowContainer is removed.

            if (mParent != null) {

                mParent.getPendingTransaction().merge(getPendingTransaction());

            }



            setSurfaceControl(null);

            setSurfaceControl(null);

            mLastSurfacePosition.set(0, 0);

            mLastSurfacePosition.set(0, 0);

            scheduleAnimation();

            scheduleAnimation();