Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86cf0cdf authored by Justin Mattson's avatar Justin Mattson
Browse files

Reverse movement direction of DPAD events 

The first way I had it produces somewhat unexpected behavior. If you
scroll past the top of the list, focus moves down to the control
below.

This changes it so scrolling past the bottom of the list moves focus
to the next control below.

Change-Id: I886e1854df85ceb203dac61c7f8c7daf6749e90e
parent 1a7cfd67

core/java/android/widget/NumberPicker.java

+2 −2
Original line number Diff line number Diff line
@@ -948,13 +948,13 @@ public class NumberPicker extends LinearLayout { 
                }

                switch (event.getAction()) {

                    case KeyEvent.ACTION_DOWN:

                        if (mWrapSelectorWheel || (keyCode == KeyEvent.KEYCODE_DPAD_UP)

                        if (mWrapSelectorWheel || (keyCode == KeyEvent.KEYCODE_DPAD_DOWN)

                                ? getValue() < getMaxValue() : getValue() > getMinValue()) {

                            requestFocus();

                            mLastHandledDownDpadKeyCode = keyCode;

                            removeAllCallbacks();

                            if (mFlingScroller.isFinished()) {

                                changeValueByOne(keyCode == KeyEvent.KEYCODE_DPAD_UP);

                                changeValueByOne(keyCode == KeyEvent.KEYCODE_DPAD_DOWN);

                            }

                            return true;

                        }