Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86cafeef authored by Jorge Gil's avatar Jorge Gil
Browse files

Log Handle Menu metrics 

For taps on the windowing options inside the handle menu: to-desktop,
to-split or to-fullscreen

Bug: 341320112
Test: verified logs with go/atomtester
Flag: EXEMPT adding logs
Change-Id: I738c0dacbf6b6db05fe34302e06f93a3201c7f46
parent f023f447

libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopModeUiEventLogger.kt

+7 −1
Original line number Diff line number Diff line
@@ -106,7 +106,13 @@ class DesktopModeUiEventLogger( 
        @UiEvent(doc = "Double tap on window header to maximize it in desktop windowing mode")

        DESKTOP_WINDOW_HEADER_DOUBLE_TAP_TO_MAXIMIZE(1724),

        @UiEvent(doc = "Tap on the window Handle to open the Handle Menu")

        DESKTOP_WINDOW_APP_HANDLE_TAP(1998);

        DESKTOP_WINDOW_APP_HANDLE_TAP(1998),

        @UiEvent(doc = "Tap on the desktop mode option under app handle menu")

        DESKTOP_WINDOW_APP_HANDLE_MENU_TAP_TO_DESKTOP_MODE(1999),

        @UiEvent(doc = "Tap on the split screen option under app handle menu")

        DESKTOP_WINDOW_APP_HANDLE_MENU_TAP_TO_SPLIT_SCREEN(2000),

        @UiEvent(doc = "Tap on the full screen option under app handle menu")

        DESKTOP_WINDOW_APP_HANDLE_MENU_TAP_TO_FULL_SCREEN(2001);



        override fun getId(): Int = mId

    }

libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/DesktopModeWindowDecorViewModel.java

+9 −0
Original line number Diff line number Diff line
@@ -643,6 +643,11 @@ public class DesktopModeWindowDecorViewModel implements WindowDecorViewModel, 
        decoration.addCaptionInset(wct);

        mDesktopTasksController.moveTaskToDesktop(taskId, wct, source);

        decoration.closeHandleMenu();



        if (source == DesktopModeTransitionSource.APP_HANDLE_MENU_BUTTON) {

            mDesktopModeUiEventLogger.log(decoration.mTaskInfo,

                    DesktopUiEventEnum.DESKTOP_WINDOW_APP_HANDLE_MENU_TAP_TO_DESKTOP_MODE);

        }

    }



    private void onToFullscreen(int taskId) {
@@ -658,6 +663,8 @@ public class DesktopModeWindowDecorViewModel implements WindowDecorViewModel, 
            mDesktopTasksController.moveToFullscreen(taskId,

                    DesktopModeTransitionSource.APP_HANDLE_MENU_BUTTON);

        }

        mDesktopModeUiEventLogger.log(decoration.mTaskInfo,

                DesktopUiEventEnum.DESKTOP_WINDOW_APP_HANDLE_MENU_TAP_TO_FULL_SCREEN);

    }



    private void onToSplitScreen(int taskId) {
@@ -670,6 +677,8 @@ public class DesktopModeWindowDecorViewModel implements WindowDecorViewModel, 
        // we shouldn't receive input for it any longer.

        decoration.disposeStatusBarInputLayer();

        mDesktopTasksController.requestSplit(decoration.mTaskInfo, false /* leftOrTop */);

        mDesktopModeUiEventLogger.log(decoration.mTaskInfo,

                DesktopUiEventEnum.DESKTOP_WINDOW_APP_HANDLE_MENU_TAP_TO_SPLIT_SCREEN);

    }



    private void onNewWindow(int taskId) {