Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8648a154 authored by Felipe Leme's avatar Felipe Leme
Browse files

Using Message.obtain() to decrease number of Messages allocated. 

BUG: 26906985
Change-Id: Ide8c6e308dcc83e9627ec775a4d977d17cd2f0a9
parent 26288783

packages/Shell/src/com/android/shell/BugreportProgressService.java

+7 −11
Original line number Original line Diff line number Diff line
@@ -149,6 +149,9 @@ public class BugreportProgressService extends Service { 
    private static final int MSG_SCREENSHOT_REQUEST = 4;

    private static final int MSG_SCREENSHOT_REQUEST = 4;

    private static final int MSG_SCREENSHOT_RESPONSE = 5;

    private static final int MSG_SCREENSHOT_RESPONSE = 5;





    // Passed to Message.obtain() when msg.arg2 is not used.

    private static final int UNUSED_ARG2 = -2;



    /**

    /**

     * Delay before a screenshot is taken.

     * Delay before a screenshot is taken.

     * <p>

     * <p>
@@ -664,11 +667,8 @@ public class BugreportProgressService extends Service { 
        final String screenshotPath =

        final String screenshotPath =

                new File(mScreenshotsDir, info.getPathNextScreenshot()).getAbsolutePath();

                new File(mScreenshotsDir, info.getPathNextScreenshot()).getAbsolutePath();





        final Message requestMsg = new Message();

        Message.obtain(mScreenshotHandler, MSG_SCREENSHOT_REQUEST, id, UNUSED_ARG2, screenshotPath)

        requestMsg.what = MSG_SCREENSHOT_REQUEST;

                .sendToTarget();

        requestMsg.arg1 = id;

        requestMsg.obj = screenshotPath;

        mScreenshotHandler.sendMessage(requestMsg);

    }

    }





    /**

    /**
@@ -694,12 +694,8 @@ public class BugreportProgressService extends Service { 
        boolean taken = takeScreenshot(mContext, screenshotFile);

        boolean taken = takeScreenshot(mContext, screenshotFile);

        setTakingScreenshot(false);

        setTakingScreenshot(false);





        final Message resultMsg = new Message();

        Message.obtain(mMainHandler, MSG_SCREENSHOT_RESPONSE, requestMsg.arg1, taken ? 1 : 0,

        resultMsg.what = MSG_SCREENSHOT_RESPONSE;

                screenshotFile).sendToTarget();

        resultMsg.arg1 = requestMsg.arg1;

        resultMsg.arg2 = taken ? 1 : 0;

        resultMsg.obj = screenshotFile;

        mMainHandler.sendMessage(resultMsg);

    }

    }





    private void handleScreenshotResponse(Message resultMsg) {

    private void handleScreenshotResponse(Message resultMsg) {