Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 85dae98c authored by Stephen Hines's avatar Stephen Hines
Browse files

Test for unsigned RS setters. 

BUG=6764163

This verifies that we don't trample memory with our unsigned set_*()
operations. Previous versions of llvm-rs-cc generated code that could
accidentally overwrite neighboring locations (due to setVar() being
called on the larger Dalvik types for unsigned globals).

Change-Id: I014496122a05cf425efa160978d0738a5233742e
parent 53678e9d

tests/RenderScriptTests/tests/src/com/android/rs/test/RSTestCore.java

+1 −0
Original line number Diff line number Diff line
@@ -67,6 +67,7 @@ public class RSTestCore { 
        unitTests.add(new UT_primitives(this, mRes, mCtx));

        unitTests.add(new UT_constant(this, mRes, mCtx));

        unitTests.add(new UT_vector(this, mRes, mCtx));

        unitTests.add(new UT_unsigned(this, mRes, mCtx));

        unitTests.add(new UT_array_init(this, mRes, mCtx));

        unitTests.add(new UT_array_alloc(this, mRes, mCtx));

        unitTests.add(new UT_clamp(this, mRes, mCtx));

tests/RenderScriptTests/tests/src/com/android/rs/test/UT_unsigned.java

0 → 100644
+60 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2012 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



package com.android.rs.test;



import android.content.Context;

import android.content.res.Resources;

import android.renderscript.*;



public class UT_unsigned extends UnitTest {

    private Resources mRes;



    protected UT_unsigned(RSTestCore rstc, Resources res, Context ctx) {

        super(rstc, "Unsigned", ctx);

        mRes = res;

    }



    private boolean initializeGlobals(ScriptC_unsigned s) {

        short pUC = s.get_uc();

        if (pUC != 5) {

            return false;

        }

        s.set_uc((short)129);



        long pUI = s.get_ui();

        if (pUI != 37) {

            return false;

        }

        s.set_ui(0x7fffffff);



        return true;

    }



    public void run() {

        RenderScript pRS = RenderScript.create(mCtx);

        ScriptC_unsigned s = new ScriptC_unsigned(pRS, mRes, R.raw.unsigned);

        pRS.setMessageHandler(mRsMessage);

        if (!initializeGlobals(s)) {

            failTest();

        } else {

            s.invoke_unsigned_test();

            pRS.finish();

            waitForMessage();

        }

        pRS.destroy();

    }

}

tests/RenderScriptTests/tests/src/com/android/rs/test/unsigned.rs

0 → 100644
+36 −0
Original line number Diff line number Diff line 
#include "shared.rsh"



// Testing unsigned types for Bug 6764163

unsigned int ui = 37;

unsigned char uc = 5;



static bool test_unsigned() {

    bool failed = false;



    rsDebug("ui", ui);

    rsDebug("uc", uc);

    _RS_ASSERT(ui == 0x7fffffff);

    _RS_ASSERT(uc == 129);



    if (failed) {

        rsDebug("test_unsigned FAILED", -1);

    }

    else {

        rsDebug("test_unsigned PASSED", 0);

    }



    return failed;

}



void unsigned_test() {

    bool failed = false;

    failed |= test_unsigned();



    if (failed) {

        rsSendToClientBlocking(RS_MSG_TEST_FAILED);

    }

    else {

        rsSendToClientBlocking(RS_MSG_TEST_PASSED);

    }

}