Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 856a5ac7 authored by Yorke Lee's avatar Yorke Lee
Browse files

Filter list of possible default dialers 

Make sure they handle the ACTION_DIAL intent with the tel scheme

Bug: 20304411
Change-Id: I1822eff8bc014d4679352165ebe2bc819b82f75b
parent ff623a5a

telecomm/java/android/telecom/DefaultDialerManager.java

+36 −5
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ import android.content.Intent; 
import android.content.pm.ActivityInfo;

import android.content.pm.PackageManager;

import android.content.pm.ResolveInfo;

import android.net.Uri;

import android.provider.Settings;

import android.text.TextUtils;
@@ -120,14 +121,14 @@ public class DefaultDialerManager { 


        for (ResolveInfo resolveInfo : resolveInfoList) {

            final ActivityInfo activityInfo = resolveInfo.activityInfo;

            if (activityInfo == null) {

                continue;

            }

            if (activityInfo != null && !packageNames.contains(activityInfo.packageName)) {

                packageNames.add(activityInfo.packageName);

            }

        }



        // TODO: Filter for apps that don't handle DIAL intent with tel scheme

        return packageNames;

        final Intent dialIntentWithTelScheme = new Intent(Intent.ACTION_DIAL);

        dialIntentWithTelScheme.setData(Uri.fromParts(PhoneAccount.SCHEME_TEL, "", null));

        return filterByIntent(context, packageNames, dialIntentWithTelScheme);

    }



    /**
@@ -151,6 +152,36 @@ public class DefaultDialerManager { 
                || packageName.equals(tm.getSystemDialerPackage());

    }



    /**

     * Filter a given list of package names for those packages that contain an activity that has

     * an intent filter for a given intent.

     *

     * @param context A valid context

     * @param packageNames List of package names to filter.

     * @return The filtered list.

     */

    private static List<String> filterByIntent(Context context, List<String> packageNames,

            Intent intent) {

        if (packageNames == null || packageNames.isEmpty()) {

            return new ArrayList<>();

        }



        final List<String> result = new ArrayList<>();

        final List<ResolveInfo> resolveInfoList =

                context.getPackageManager().queryIntentActivities(intent, 0);

        final int length = resolveInfoList.size();

        for (int i = 0; i < length; i++) {

            final ActivityInfo info = resolveInfoList.get(i).activityInfo;

            if (info != null && packageNames.contains(info.packageName)

                    && !result.contains(info.packageName)) {

                result.add(info.packageName);

            }

        }



        return result;

    }





    private static TelecomManager getTelecomManager(Context context) {

        return (TelecomManager) context.getSystemService(Context.TELECOM_SERVICE);

    }