Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 850f9387 authored by Matt Pietal's avatar Matt Pietal
Browse files

Controls UI - Show timeout msg and not controls on error 

There was some confusion around people seeing all devices with a
status of 'device removed' on timeout. Show the msg instead and not
the favorited controls

Fixes: 159596183
Test: manually set load timeout to 1s
Change-Id: I7cb0f74c2080f3537f8df84ea5eb0fd779285dcf
parent ace942e5

packages/SystemUI/src/com/android/systemui/controls/controller/ControlsProviderLifecycleManager.kt

+1 −1
Original line number Diff line number Diff line
@@ -73,7 +73,7 @@ class ControlsProviderLifecycleManager( 


    companion object {

        private const val BIND_RETRY_DELAY = 1000L // ms

        private const val LOAD_TIMEOUT_SECONDS = 30L // seconds

        private const val LOAD_TIMEOUT_SECONDS = 20L // seconds

        private const val MAX_BIND_RETRIES = 5

        private const val DEBUG = true

        private val BIND_FLAGS = Context.BIND_AUTO_CREATE or Context.BIND_FOREGROUND_SERVICE

packages/SystemUI/src/com/android/systemui/controls/management/ControlsFavoritingActivity.kt

+24 −22
Original line number Diff line number Diff line
@@ -174,7 +174,7 @@ class ControlsFavoritingActivity @Inject constructor( 
                        subtitleView.visibility = View.GONE

                    } else {

                        statusText.visibility = View.GONE

                    }



                        pageIndicator.setNumPages(listOfStructures.size)

                        pageIndicator.setLocation(0f)

                        pageIndicator.visibility =
@@ -192,13 +192,15 @@ class ControlsFavoritingActivity @Inject constructor( 
                                        pageIndicator.getLocationOnScreen(p)

                                        val x = p[0] + pageIndicator.width / 2

                                        val y = p[1] + pageIndicator.height

                                    mTooltipManager?.show(R.string.controls_structure_tooltip, x, y)

                                        mTooltipManager?.show(

                                            R.string.controls_structure_tooltip, x, y)

                                    }

                                }

                            })

                        }.start()

                        ControlsAnimations.enterAnimation(structurePager).start()

                    }

                }

            }, Consumer { runnable -> cancelLoadRunnable = runnable })

        }

    }