Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84dbd610 authored by Chiachang Wang's avatar Chiachang Wang
Browse files

Use system api for shell command handling 

ConnectivityService should not use ShellCommand since it's @hide
which does not accessible in mainline modules. Replace it with
system api for mainline.

Bug: 170598012
Test: adb shell cmd connectivity airplane-mode enable
Test: adb shell cmd connectivity airplane-mode disable
Change-Id: I47e7a371c19eb18eac643fe9a2ab481bec5743c2
parent 02ca5fcb

services/core/java/com/android/server/ConnectivityService.java

+7 −9
Original line number Diff line number Diff line
@@ -140,6 +140,7 @@ import android.net.util.LinkPropertiesUtils.CompareOrUpdateResult; 
import android.net.util.LinkPropertiesUtils.CompareResult;

import android.net.util.MultinetworkPolicyTracker;

import android.net.util.NetdService;

import android.os.BasicShellCommandHandler;

import android.os.Binder;

import android.os.Build;

import android.os.Bundle;
@@ -156,11 +157,8 @@ import android.os.PersistableBundle; 
import android.os.PowerManager;

import android.os.Process;

import android.os.RemoteException;

import android.os.ResultReceiver;

import android.os.ServiceManager;

import android.os.ServiceSpecificException;

import android.os.ShellCallback;

import android.os.ShellCommand;

import android.os.SystemClock;

import android.os.SystemProperties;

import android.os.UserHandle;
@@ -7658,14 +7656,14 @@ public class ConnectivityService extends IConnectivityManager.Stub 
    }



    @Override

    public void onShellCommand(@NonNull FileDescriptor in, @NonNull FileDescriptor out,

            FileDescriptor err, @NonNull String[] args, ShellCallback callback,

            @NonNull ResultReceiver resultReceiver) {

        (new ShellCmd()).exec(this, in, out, err, args, callback, resultReceiver);

    public int handleShellCommand(@NonNull ParcelFileDescriptor in,

            @NonNull ParcelFileDescriptor out, @NonNull ParcelFileDescriptor err,

            @NonNull String[] args) {

        return new ShellCmd().exec(this, in.getFileDescriptor(), out.getFileDescriptor(),

                err.getFileDescriptor(), args);

    }



    private class ShellCmd extends ShellCommand {



    private class ShellCmd extends BasicShellCommandHandler {

        @Override

        public int onCommand(String cmd) {

            if (cmd == null) {