Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84967ebf authored by Adam Bookatz's avatar Adam Bookatz
Browse files

UserProperty cross-binder warning only for SYSTEM 

We currently warn when getUserProperties() is called where the
callingUid differs from the processUid. This is really only an
interesting situation when called from the SYSTEM (uid 1000), since
otherwise the binder call will equate the two anyway.

Since this is now of much lower frequency, we can log this warning for
regular devices too, not just eng builds.

Test: Manual. Just a logging change.
Flag: EXEMPT bugfix
Change-Id: I9be85c825549743ad281eedd6da550548d011642
parent c23a55ed

core/java/android/os/UserManager.java

+3 −3
Original line number Diff line number Diff line
@@ -3928,9 +3928,9 @@ public class UserManager { 


        final int callingUid = Binder.getCallingUid();

        final int processUid = Process.myUid();

        if (Build.isDebuggable() && callingUid != processUid) {

            Log.w(TAG, "Uid " + processUid + " is fetching a copy of UserProperties on"

                            + " behalf of callingUid " + callingUid + ". Possibly"

        if (processUid == Process.SYSTEM_UID && callingUid != processUid) {

            Log.w(TAG, "The System (uid " + processUid + ") is fetching a copy of"

                            + " UserProperties on behalf of callingUid " + callingUid + ". Possibly"

                            + " it should carefully first clearCallingIdentity or perhaps use"

                            + " UserManagerInternal.getUserProperties() instead?",

                    new Throwable());