Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 844c7087 authored by Edgar Arriaga's avatar Edgar Arriaga
Browse files

Clean up skip_home_art_pins ablatin study flag 

Bug: 340935152
Test: Check dumpsys pinner no longer skips the art pins.
Flag: EXEMPT removing skip_home_art_pins
Change-Id: I64cbd1eec2c34e51693f6678b9f14237e92c7935
parent 8cf31570

services/core/java/com/android/server/PinnerService.java

+1 −4
Original line number Diff line number Diff line
@@ -22,7 +22,6 @@ import static android.os.Process.SYSTEM_UID; 


import static com.android.server.flags.Flags.pinGlobalQuota;

import static com.android.server.flags.Flags.pinWebview;

import static com.android.server.flags.Flags.skipHomeArtPins;



import android.annotation.EnforcePermission;

import android.annotation.IntDef;
@@ -872,8 +871,6 @@ public final class PinnerService extends SystemService { 


        long apkPinSizeLimit = pinSizeLimit;



        boolean shouldSkipArtPins = key == KEY_HOME && skipHomeArtPins();



        for (String apk: apks) {

            if (apkPinSizeLimit <= 0) {

                Slog.w(TAG, "Reached to the pin size limit. Skipping: " + apk);
@@ -882,7 +879,7 @@ public final class PinnerService extends SystemService { 
            }



            String pinGroup = getNameForKey(key);

            boolean shouldPinDeps = apk.equals(appInfo.sourceDir) && !shouldSkipArtPins;

            boolean shouldPinDeps = apk.equals(appInfo.sourceDir);

            PinnedFile pf = pinFile(apk, apkPinSizeLimit, appInfo, pinGroup, shouldPinDeps);

            if (pf == null) {

                Slog.e(TAG, "Failed to pin " + apk);

services/core/java/com/android/server/flags/pinner.aconfig

+0 −7
Original line number Diff line number Diff line
@@ -17,10 +17,3 @@ flag { 
    purpose: PURPOSE_BUGFIX

  }

}
 


flag {

    name: "skip_home_art_pins"

    namespace: "system_performance"

    description: "Ablation study flag that controls if home app odex/vdex files should be pinned in memory."

    bug: "340935152"

}
 
 No newline at end of file