Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8412b132 authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "Fix cursor not blinking when view re-added to layout"

parents 913ba5ee 61d98288

core/java/android/widget/Editor.java

+10 −2
Original line number Diff line number Diff line
@@ -709,7 +709,10 @@ public class Editor { 
        }



        getPositionListener().addSubscriber(mCursorAnchorInfoNotifier, true);

        makeBlink();

        // Call resumeBlink here instead of makeBlink to ensure that if mBlink is not null the

        // Blink object is uncancelled.  This ensures when a view is removed and added back the

        // cursor will resume blinking.

        resumeBlink();

    }



    void onDetachedFromWindow() {
@@ -1081,8 +1084,10 @@ public class Editor { 
    private void resumeBlink() {

        if (mBlink != null) {

            mBlink.uncancel();

            makeBlink();

        }

        // Moving makeBlink outside of the null check block ensures that mBlink object gets

        // instantiated when the view is added to the window if mBlink is still null.

        makeBlink();

    }



    void adjustInputType(boolean password, boolean passwordInputType,
@@ -2862,6 +2867,9 @@ public class Editor { 
        if (shouldBlink()) {

            mShowCursor = SystemClock.uptimeMillis();

            if (mBlink == null) mBlink = new Blink();

            // Call uncancel as mBlink could have previously been cancelled and cursor will not

            // resume blinking unless uncancelled.

            mBlink.uncancel();

            mTextView.removeCallbacks(mBlink);

            mTextView.postDelayed(mBlink, BLINK);

        } else {