Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83e67a66 authored by Arnab Banerjee's avatar Arnab Banerjee Committed by Song Chun Fan
Browse files

Fix TypedArray instance leak in ParsingPackageUtils. 

TypedArray instance was not closed after creation due to recycle method not being invoked. Added recycle call.

Bug: 337976070
FIXES: 337976070
Change-Id: I222e33209e6b66f344e24ae1ca232ca7312da087
parent cd53cb57

core/java/com/android/internal/pm/pkg/parsing/ParsingPackageUtils.java

+9 −5
Original line number Diff line number Diff line
@@ -1911,12 +1911,16 @@ public class ParsingPackageUtils { 
            } else if (parser.getName().equals("package")) {

                final TypedArray sa = res.obtainAttributes(parser,

                        R.styleable.AndroidManifestQueriesPackage);

                try {

                    final String packageName = sa.getNonConfigurationString(

                            R.styleable.AndroidManifestQueriesPackage_name, 0);

                    if (TextUtils.isEmpty(packageName)) {

                        return input.error("Package name is missing from package tag.");

                    }

                    pkg.addQueriesPackage(packageName.intern());

                } finally {

                    sa.recycle();

                }

            } else if (parser.getName().equals("provider")) {

                final TypedArray sa = res.obtainAttributes(parser,

                        R.styleable.AndroidManifestQueriesProvider);