Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83bea973 authored by Mathieu Chartier's avatar Mathieu Chartier
Browse files

Clean up class preloading 

Remove logic to set heap target utilization to 0.8. The default is
0.75 and this should not have any fragmentation benefit since the
GC is compacting.

Removed some unused logging and a variable.

Test: TH

Change-Id: Ife7219e94fa0aa7f489569e16248cdd23d09089a
parent cc55cca9

core/java/com/android/internal/os/ZygoteInit.java

+0 −15
Original line number Diff line number Diff line
@@ -94,11 +94,6 @@ public class ZygoteInit { 
    private static final int LOG_BOOT_PROGRESS_PRELOAD_START = 3020;

    private static final int LOG_BOOT_PROGRESS_PRELOAD_END = 3030;



    /**

     * when preloading, GC after allocating this many bytes

     */

    private static final int PRELOAD_GC_THRESHOLD = 50000;



    private static final String ABI_LIST_ARG = "--abi-list=";



    // TODO (chriswailes): Re-name this --zygote-socket-name= and then add a
@@ -278,11 +273,6 @@ public class ZygoteInit { 
            droppedPriviliges = true;

        }



        // Alter the target heap utilization.  With explicit GCs this

        // is not likely to have any effect.

        float defaultUtilization = runtime.getTargetHeapUtilization();

        runtime.setTargetHeapUtilization(0.8f);



        try {

            BufferedReader br =

                    new BufferedReader(new InputStreamReader(is), Zygote.SOCKET_BUFFER_SIZE);
@@ -298,9 +288,6 @@ public class ZygoteInit { 


                Trace.traceBegin(Trace.TRACE_TAG_DALVIK, line);

                try {

                    if (false) {

                        Log.v(TAG, "Preloading " + line + "...");

                    }

                    // Load and explicitly initialize the given class. Use

                    // Class.forName(String, boolean, ClassLoader) to avoid repeated stack lookups

                    // (to derive the caller's class-loader). Use true to force initialization, and
@@ -331,8 +318,6 @@ public class ZygoteInit { 
            Log.e(TAG, "Error reading " + PRELOADED_CLASSES + ".", e);

        } finally {

            IoUtils.closeQuietly(is);

            // Restore default.

            runtime.setTargetHeapUtilization(defaultUtilization);



            // Fill in dex caches with classes, fields, and methods brought in by preloading.

            Trace.traceBegin(Trace.TRACE_TAG_DALVIK, "PreloadDexCaches");