Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83a9937f authored by Chris Blume's avatar Chris Blume
Browse files

Add explicit values to ABI enums in libs/hwui 

In a separate code review we agreed that at ABI boundaries it feels nice
to explicitly call out enum values rather than rely on the rules of
C/C++ which others may not be comfortable with.

This CL adds explicit values to enums inside draw_gl.h.

Test: I built and tested on a Pixel 2.
Change-Id: I64c03e2684c1ab096a9c0665e4ed3d8b7bb22ac7
parent e59ac13c

native/webview/plat_support/draw_gl.h

+6 −6
Original line number Diff line number Diff line
@@ -43,9 +43,9 @@ struct AwDrawGLInfo { 
  // Input: tells the draw function what action to perform.

  enum Mode {

    kModeDraw = 0,

    kModeProcess,

    kModeProcessNoContext,

    kModeSync,

    kModeProcess = 1,

    kModeProcessNoContext = 2,

    kModeSync = 3,

  } mode;



  // Input: current clip rect in surface coordinates. Reflects the current state
@@ -93,9 +93,9 @@ typedef void (AwDrawGLFunction)(long view_context, 
                                AwDrawGLInfo* draw_info,

                                void* spare);

enum AwMapMode {

  MAP_READ_ONLY,

  MAP_WRITE_ONLY,

  MAP_READ_WRITE,

  MAP_READ_ONLY = 0,

  MAP_WRITE_ONLY = 1,

  MAP_READ_WRITE = 2,

};



// Called to create a GraphicBuffer