Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83984725 authored by Shraddha Basantwani's avatar Shraddha Basantwani
Browse files

CEC : Add validator for deck control message 

Test: atest HdmiCecMessageValidatorTest
Bug: 170811408
Change-Id: I64897e9ae3f35f71dd3fb38b00b2d8e924b88b30
parent b65bb171

services/core/java/com/android/server/hdmi/HdmiCecMessageValidator.java

+2 −0
Original line number Diff line number Diff line
@@ -149,6 +149,8 @@ public class HdmiCecMessageValidator { 
                new AsciiValidator(3), DEST_BROADCAST);



        // TODO: Handle messages for the Deck Control.

        addValidationInfo(

                Constants.MESSAGE_DECK_CONTROL, new OneByteRangeValidator(0x01, 0x04), DEST_DIRECT);



        // TODO: Handle messages for the Tuner Control.

services/tests/servicestests/src/com/android/server/hdmi/HdmiCecMessageValidatorTest.java

+11 −0
Original line number Diff line number Diff line
@@ -353,6 +353,17 @@ public class HdmiCecMessageValidatorTest { 
        assertMessageValidity("40:35:EE:52:4A").isEqualTo(ERROR_PARAMETER);

    }



    @Test

    public void isValid_deckControl() {

        assertMessageValidity("40:42:01:6E").isEqualTo(OK);

        assertMessageValidity("40:42:04").isEqualTo(OK);



        assertMessageValidity("4F:42:01").isEqualTo(ERROR_DESTINATION);

        assertMessageValidity("F0:42:04").isEqualTo(ERROR_SOURCE);

        assertMessageValidity("40:42").isEqualTo(ERROR_PARAMETER_SHORT);

        assertMessageValidity("40:42:05").isEqualTo(ERROR_PARAMETER);

    }



    private IntegerSubject assertMessageValidity(String message) {

        return assertThat(mHdmiCecMessageValidator.isValid(buildMessage(message)));

    }