Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83339155 authored by Xiaowen Lei's avatar Xiaowen Lei
Browse files

Deprecate `setIsDreaming` in favor of `setUiSurface`. 

Bug: 266139726
Test: manual
Test: DreamSmartspaceControllerTest
Test: LockscreenSmartspaceControllerTest
Change-Id: I35e2b0a1d8b3f203371dfb23b9a3c0d7590ce4d5
parent 6116f0a6

packages/SystemUI/plugin/bcsmartspace/src/com/android/systemui/plugins/BcSmartspaceDataPlugin.java

+0 −6
Original line number Diff line number Diff line
@@ -117,12 +117,6 @@ public interface BcSmartspaceDataPlugin extends Plugin { 
         */

        void setPrimaryTextColor(int color);



        /**

         * When the view is displayed on Dream, set the flag to true, immediately after the view is

         * created.

         */

        void setIsDreaming(boolean isDreaming);



        /**

         * Set the UI surface for the cards. Should be called immediately after the view is created.

         */

packages/SystemUI/src/com/android/systemui/smartspace/dagger/SmartspaceViewComponent.kt

+2 −1
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ import android.view.View 
import android.view.ViewGroup

import com.android.systemui.plugins.ActivityStarter

import com.android.systemui.plugins.BcSmartspaceDataPlugin

import com.android.systemui.plugins.BcSmartspaceDataPlugin.UI_SURFACE_DREAM

import com.android.systemui.plugins.FalsingManager

import com.android.systemui.smartspace.dagger.SmartspaceViewComponent.SmartspaceViewModule.PLUGIN

import dagger.BindsInstance
@@ -57,7 +58,7 @@ interface SmartspaceViewComponent { 
                BcSmartspaceDataPlugin.SmartspaceView {

            val ssView = plugin.getView(parent)

            // Currently, this is only used to provide SmartspaceView on Dream surface.

            ssView.setIsDreaming(true)

            ssView.setUiSurface(UI_SURFACE_DREAM)

            ssView.registerDataProvider(plugin)



            ssView.setIntentStarter(object : BcSmartspaceDataPlugin.IntentStarter {

packages/SystemUI/tests/src/com/android/systemui/smartspace/DreamSmartspaceControllerTest.kt

+0 −2
Original line number Diff line number Diff line
@@ -99,8 +99,6 @@ class DreamSmartspaceControllerTest : SysuiTestCase() { 


        override fun setPrimaryTextColor(color: Int) {}



        override fun setIsDreaming(isDreaming: Boolean) {}



        override fun setUiSurface(uiSurface: String) {}



        override fun setDozeAmount(amount: Float) {}

packages/SystemUI/tests/src/com/android/systemui/statusbar/lockscreen/LockscreenSmartspaceControllerTest.kt

+0 −9
Original line number Diff line number Diff line
@@ -780,9 +780,6 @@ class LockscreenSmartspaceControllerTest : SysuiTestCase() { 
            override fun setPrimaryTextColor(color: Int) {

            }



            override fun setIsDreaming(isDreaming: Boolean) {

            }



            override fun setUiSurface(uiSurface: String) {

            }
@@ -811,9 +808,6 @@ class LockscreenSmartspaceControllerTest : SysuiTestCase() { 
            override fun setPrimaryTextColor(color: Int) {

            }



            override fun setIsDreaming(isDreaming: Boolean) {

            }



            override fun setUiSurface(uiSurface: String) {

            }
@@ -838,9 +832,6 @@ class LockscreenSmartspaceControllerTest : SysuiTestCase() { 
            override fun setPrimaryTextColor(color: Int) {

            }



            override fun setIsDreaming(isDreaming: Boolean) {

            }



            override fun setUiSurface(uiSurface: String) {

            }