Commit 825992f5 authored Jul 28, 2012 by Jake Wharton

Return early when checking divider before child zero.

Previously the `getChildAt` method would be called with an index of -1 which
would lead to an exception being thrown and caught. This is unnecessary since
we know there will never be a divider before the first child. It also avoids
additional object creation since this method can be invoked quite frequently.

Change-Id: Iab44520d5d52f96a829a009cdd1201696edbf9a4

parent 2c932143

core/java/com/android/internal/view/menu/ActionMenuView.java

+3 −0

Original line number	Diff line number	Diff line
		@@ -524,6 +524,9 @@ public class ActionMenuView extends LinearLayout implements MenuBuilder.ItemInvo

		@Override
		protected boolean hasDividerBeforeChildAt(int childIndex) {
		if (childIndex == 0) {
		return false;
		}
		final View childBefore = getChildAt(childIndex - 1);
		final View child = getChildAt(childIndex);
		boolean result = false;