Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8229dfd1 authored by Gustav Sennton's avatar Gustav Sennton
Browse files

Avoid a bunch of log spam in SmartReplyConstantsTest. 

DeviceConfig logs errors when trying to read e.g. an integer and the
value provided isn't an integer. However, DeviceConfig avoids logging
the error if the value is null. So with this CL we use null as the reset
value for SmartReplyConstantsTest.

Bug: 129538548
Test: atest SmartReplyConstantsTest, and check logcat for spam.
Change-Id: I4c714b7e808163c20fccc5cdca734a255c698ede
parent 2a127a77

packages/SystemUI/tests/src/com/android/systemui/statusbar/policy/SmartReplyConstantsTest.java

+8 −8
Original line number Diff line number Diff line
@@ -95,7 +95,7 @@ public class SmartReplyConstantsTest extends SysuiTestCase { 
        triggerConstantsOnChange();

        assertEquals(false, mConstants.requiresTargetingP());



        overrideSetting(SystemUiDeviceConfigFlags.SSIN_REQUIRES_TARGETING_P, "");

        overrideSetting(SystemUiDeviceConfigFlags.SSIN_REQUIRES_TARGETING_P, null);

        triggerConstantsOnChange();

        assertEquals(true, mConstants.requiresTargetingP());

    }
@@ -223,21 +223,21 @@ public class SmartReplyConstantsTest extends SysuiTestCase { 


    private void resetAllDeviceConfigFlags() {

        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,

                SystemUiDeviceConfigFlags.SSIN_ENABLED, "", false /* makeDefault */);

                SystemUiDeviceConfigFlags.SSIN_ENABLED, null, false /* makeDefault */);

        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,

                SystemUiDeviceConfigFlags.SSIN_REQUIRES_TARGETING_P, "", false /* makeDefault */);

                SystemUiDeviceConfigFlags.SSIN_REQUIRES_TARGETING_P, null, false /* makeDefault */);

        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,

                SystemUiDeviceConfigFlags.SSIN_MAX_SQUEEZE_REMEASURE_ATTEMPTS, "",

                SystemUiDeviceConfigFlags.SSIN_MAX_SQUEEZE_REMEASURE_ATTEMPTS, null,

                false /* makeDefault */);

        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,

                SystemUiDeviceConfigFlags.SSIN_EDIT_CHOICES_BEFORE_SENDING, "",

                SystemUiDeviceConfigFlags.SSIN_EDIT_CHOICES_BEFORE_SENDING, null,

                false /* makeDefault */);

        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,

                SystemUiDeviceConfigFlags.SSIN_SHOW_IN_HEADS_UP, "", false /* makeDefault */);

                SystemUiDeviceConfigFlags.SSIN_SHOW_IN_HEADS_UP, null, false /* makeDefault */);

        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,

                SystemUiDeviceConfigFlags.SSIN_MIN_NUM_SYSTEM_GENERATED_REPLIES, "",

                SystemUiDeviceConfigFlags.SSIN_MIN_NUM_SYSTEM_GENERATED_REPLIES, null,

                false /* makeDefault */);

        DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,

                SystemUiDeviceConfigFlags.SSIN_MAX_NUM_ACTIONS, "", false /* makeDefault */);

                SystemUiDeviceConfigFlags.SSIN_MAX_NUM_ACTIONS, null, false /* makeDefault */);

    }

}