Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80f7b015 authored by Winson Chung's avatar Winson Chung
Browse files

Removing duplicate string in Recents. 

- Use the same string when showing incompatible apps as the string that
  we show when launching an incompatible app.

Bug: 35373622
Test: Launch recents with incompatible app while docked, verify string
Change-Id: I8d9a7d6e96a384ccff80ab6ff8a5e53c13d8d420
parent 76c32a35

packages/SystemUI/res/layout/recents_incompatible_app_overlay.xml

+1 −1
Original line number Diff line number Diff line
@@ -26,6 +26,6 @@ 
        android:layout_gravity="center"

        android:drawableTop="@drawable/recents_info_light"

        android:drawablePadding="8dp"

        android:text="@string/recents_incompatible_app_message"

        android:text="@string/dock_non_resizeble_failed_to_dock_text"

        android:textColor="@android:color/white" />

</FrameLayout>
 
 No newline at end of file

packages/SystemUI/res/values/strings.xml

+0 −2
Original line number Diff line number Diff line
@@ -789,8 +789,6 @@ 
    <string name="recents_launch_disabled_message"><xliff:g id="app" example="Calendar">%s</xliff:g> is disabled in safe-mode.</string>

    <!-- Recents: Stack action button string. [CHAR LIMIT=NONE] -->

    <string name="recents_stack_action_button_label">Clear all</string>

    <!-- Recents: Incompatible task message. [CHAR LIMIT=NONE] -->

    <string name="recents_incompatible_app_message">App doesn\'t support split screen</string>

    <!-- Recents: Hint text that shows on the drop targets to start multiwindow. [CHAR LIMIT=NONE] -->

    <string name="recents_drag_hint_message">Drag here to use split screen</string>

packages/SystemUI/src/com/android/systemui/recents/Recents.java

+1 −1
Original line number Diff line number Diff line
@@ -474,7 +474,7 @@ public class Recents extends SystemUI 
                return true;

            } else {

                EventBus.getDefault().send(new ShowUserToastEvent(

                        R.string.recents_incompatible_app_message, Toast.LENGTH_SHORT));

                        R.string.dock_non_resizeble_failed_to_dock_text, Toast.LENGTH_SHORT));

                return false;

            }

        } else {

packages/SystemUI/src/com/android/systemui/recents/views/TaskView.java

+2 −2
Original line number Diff line number Diff line
@@ -610,8 +610,8 @@ public class TaskView extends FixedSizeFrameLayout implements Task.TaskCallbacks 
            if (mIncompatibleAppToastView == null) {

                mIncompatibleAppToastView = Utilities.findViewStubById(this,

                        R.id.incompatible_app_toast_stub).inflate();

                TextView msg = (TextView) findViewById(com.android.internal.R.id.message);

                msg.setText(R.string.recents_incompatible_app_message);

                TextView msg = findViewById(com.android.internal.R.id.message);

                msg.setText(R.string.dock_non_resizeble_failed_to_dock_text);

            }

            mIncompatibleAppToastView.setVisibility(View.VISIBLE);

        } else if (mIncompatibleAppToastView != null) {