Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8056b7cd authored by Austin Delgado's avatar Austin Delgado
Browse files

Add RTL support to new BP layout

Test: atest com.android.systemui.biometrics
Bug: 339972854
Flag: ACONFIG constraint_bp NEXTFOOD
Change-Id: I5831efcdf987d511a1703e40d1d5af57a5534312
parent 71875b5f
Loading
Loading
Loading
Loading
+10 −7
Original line number Diff line number Diff line
@@ -26,8 +26,8 @@ android:layout_height="match_parent">
        android:paddingVertical="16dp"
        android:visibility="visible"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toStartOf="@+id/rightGuideline"
        app:layout_constraintStart_toStartOf="@+id/leftGuideline"
        app:layout_constraintRight_toLeftOf="@+id/rightGuideline"
        app:layout_constraintLeft_toLeftOf="@+id/leftGuideline"
        app:layout_constraintTop_toTopOf="@+id/topGuideline" />

    <com.android.systemui.biometrics.BiometricPromptLottieViewWrapper
@@ -35,8 +35,8 @@ android:layout_height="match_parent">
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintTop_toTopOf="parent"
        tools:srcCompat="@tools:sample/avatars" />

@@ -62,8 +62,8 @@ android:layout_height="match_parent">
        android:paddingTop="24dp"
        android:fadeScrollbars="false"
        app:layout_constraintBottom_toTopOf="@+id/button_bar"
        app:layout_constraintEnd_toStartOf="@+id/midGuideline"
        app:layout_constraintStart_toStartOf="@id/leftGuideline"
        app:layout_constraintRight_toLeftOf="@+id/midGuideline"
        app:layout_constraintLeft_toLeftOf="@id/leftGuideline"
        app:layout_constraintTop_toTopOf="@+id/topGuideline">

        <androidx.constraintlayout.widget.ConstraintLayout
@@ -88,7 +88,7 @@ android:layout_height="match_parent">
                android:layout_width="0dp"
                android:layout_height="wrap_content"
                android:textAlignment="viewStart"
                android:paddingLeft="16dp"
                android:paddingStart="16dp"
                app:layout_constraintBottom_toBottomOf="@+id/logo"
                app:layout_constraintEnd_toEndOf="parent"
                app:layout_constraintStart_toEndOf="@+id/logo"
@@ -208,6 +208,7 @@ android:layout_height="match_parent">
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:orientation="vertical"
        app:guidelineUseRtl="false"
        app:layout_constraintGuide_begin="@dimen/biometric_dialog_border_padding" />

    <androidx.constraintlayout.widget.Guideline
@@ -215,6 +216,7 @@ android:layout_height="match_parent">
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:orientation="vertical"
        app:guidelineUseRtl="false"
        app:layout_constraintGuide_end="@dimen/biometric_dialog_border_padding" />

    <androidx.constraintlayout.widget.Guideline
@@ -222,6 +224,7 @@ android:layout_height="match_parent">
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:orientation="vertical"
        app:guidelineUseRtl="false"
        app:layout_constraintGuide_begin="406dp" />

    <androidx.constraintlayout.widget.Guideline
+5 −5
Original line number Diff line number Diff line
@@ -27,7 +27,7 @@
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center_vertical"
        android:layout_marginLeft="24dp"
        android:layout_marginStart="24dp"
        android:ellipsize="end"
        android:maxLines="2"
        android:visibility="invisible"
@@ -41,7 +41,7 @@
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center_vertical"
        android:layout_marginLeft="24dp"
        android:layout_marginStart="24dp"
        android:text="@string/cancel"
        android:visibility="invisible"
        app:layout_constraintBottom_toBottomOf="parent"
@@ -54,7 +54,7 @@
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center_vertical"
        android:layout_marginLeft="24dp"
        android:layout_marginStart="24dp"
        android:visibility="invisible"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintStart_toStartOf="parent" />
@@ -66,7 +66,7 @@
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center_vertical"
        android:layout_marginRight="24dp"
        android:layout_marginEnd="24dp"
        android:ellipsize="end"
        android:maxLines="2"
        android:text="@string/biometric_dialog_confirm"
@@ -81,7 +81,7 @@
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center_vertical"
        android:layout_marginRight="24dp"
        android:layout_marginEnd="24dp"
        android:ellipsize="end"
        android:maxLines="2"
        android:text="@string/biometric_dialog_try_again"
+23 −20
Original line number Diff line number Diff line
@@ -199,29 +199,32 @@ object BiometricViewSizeBinder {
                                    iconParams.leftMargin = position.left
                                    mediumConstraintSet.clear(
                                        R.id.biometric_icon,
                                        ConstraintSet.END
                                        ConstraintSet.RIGHT
                                    )
                                    mediumConstraintSet.connect(
                                        R.id.biometric_icon,
                                        ConstraintSet.START,
                                        ConstraintSet.LEFT,
                                        ConstraintSet.PARENT_ID,
                                        ConstraintSet.START
                                        ConstraintSet.LEFT
                                    )
                                    mediumConstraintSet.setMargin(
                                        R.id.biometric_icon,
                                        ConstraintSet.START,
                                        ConstraintSet.LEFT,
                                        position.left
                                    )
                                    smallConstraintSet.clear(R.id.biometric_icon, ConstraintSet.END)
                                    smallConstraintSet.clear(
                                        R.id.biometric_icon,
                                        ConstraintSet.RIGHT
                                    )
                                    smallConstraintSet.connect(
                                        R.id.biometric_icon,
                                        ConstraintSet.START,
                                        ConstraintSet.LEFT,
                                        ConstraintSet.PARENT_ID,
                                        ConstraintSet.START
                                        ConstraintSet.LEFT
                                    )
                                    smallConstraintSet.setMargin(
                                        R.id.biometric_icon,
                                        ConstraintSet.START,
                                        ConstraintSet.LEFT,
                                        position.left
                                    )
                                }
@@ -252,32 +255,32 @@ object BiometricViewSizeBinder {
                                    iconParams.rightMargin = position.right
                                    mediumConstraintSet.clear(
                                        R.id.biometric_icon,
                                        ConstraintSet.START
                                        ConstraintSet.LEFT
                                    )
                                    mediumConstraintSet.connect(
                                        R.id.biometric_icon,
                                        ConstraintSet.END,
                                        ConstraintSet.RIGHT,
                                        ConstraintSet.PARENT_ID,
                                        ConstraintSet.END
                                        ConstraintSet.RIGHT
                                    )
                                    mediumConstraintSet.setMargin(
                                        R.id.biometric_icon,
                                        ConstraintSet.END,
                                        ConstraintSet.RIGHT,
                                        position.right
                                    )
                                    smallConstraintSet.clear(
                                        R.id.biometric_icon,
                                        ConstraintSet.START
                                        ConstraintSet.LEFT
                                    )
                                    smallConstraintSet.connect(
                                        R.id.biometric_icon,
                                        ConstraintSet.END,
                                        ConstraintSet.RIGHT,
                                        ConstraintSet.PARENT_ID,
                                        ConstraintSet.END
                                        ConstraintSet.RIGHT
                                    )
                                    smallConstraintSet.setMargin(
                                        R.id.biometric_icon,
                                        ConstraintSet.END,
                                        ConstraintSet.RIGHT,
                                        position.right
                                    )
                                }
@@ -383,15 +386,15 @@ object BiometricViewSizeBinder {
                                // Move all content to other panel
                                flipConstraintSet.connect(
                                    R.id.scrollView,
                                    ConstraintSet.START,
                                    ConstraintSet.LEFT,
                                    R.id.midGuideline,
                                    ConstraintSet.START
                                    ConstraintSet.LEFT
                                )
                                flipConstraintSet.connect(
                                    R.id.scrollView,
                                    ConstraintSet.END,
                                    ConstraintSet.RIGHT,
                                    R.id.rightGuideline,
                                    ConstraintSet.END
                                    ConstraintSet.RIGHT
                                )
                            }