Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80299748 authored by Phil Burk's avatar Phil Burk
Browse files

MidiDevice: fix connectPorts for same Process 



If connectPorts() was called for a device in the same process then
the connection would die when the ParcelFileDescriptor was closed.

Bug: 26406775
Change-Id: Id0538452593b4761ac2a93d366ade76d2e35ce73
Signed-off-by: default avatarPhil Burk <philburk@google.com>
parent 7492e75b

media/java/android/media/midi/IMidiDeviceServer.aidl

+2 −1
Original line number Diff line number Diff line
@@ -28,7 +28,8 @@ interface IMidiDeviceServer 
    void closeDevice();



    // connects the input port pfd to the specified output port

    void connectPorts(IBinder token, in ParcelFileDescriptor pfd, int outputPortNumber);

    // Returns the PID of the called process.

    int connectPorts(IBinder token, in ParcelFileDescriptor pfd, int outputPortNumber);



    MidiDeviceInfo getDeviceInfo();

    void setDeviceInfo(in MidiDeviceInfo deviceInfo);

media/java/android/media/midi/MidiDevice.java

+11 −3
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ package android.media.midi; 
import android.os.Binder;

import android.os.IBinder;

import android.os.ParcelFileDescriptor;

import android.os.Process;

import android.os.RemoteException;

import android.util.Log;
@@ -181,9 +182,16 @@ public final class MidiDevice implements Closeable { 
        }

         try {

            IBinder token = new Binder();

            mDeviceServer.connectPorts(token, pfd, outputPortNumber);

            int calleePid = mDeviceServer.connectPorts(token, pfd, outputPortNumber);

            // If the service is a different Process then it will duplicate the pfd

            // and we can safely close this one.

            // But if the service is in the same Process then closing the pfd will

            // kill the connection. So don't do that.

            if (calleePid != Process.myPid()) {

                // close our copy of the file descriptor

                IoUtils.closeQuietly(pfd);

            }



            return new MidiConnection(token, inputPort);

        } catch (RemoteException e) {

            Log.e(TAG, "RemoteException in connectPorts");

media/java/android/media/midi/MidiDeviceServer.java

+2 −1
Original line number Diff line number Diff line
@@ -254,7 +254,7 @@ public final class MidiDeviceServer implements Closeable { 
        }



        @Override

        public void connectPorts(IBinder token, ParcelFileDescriptor pfd,

        public int connectPorts(IBinder token, ParcelFileDescriptor pfd,

                int outputPortNumber) {

            MidiInputPort inputPort = new MidiInputPort(pfd, outputPortNumber);

            MidiDispatcher dispatcher = mOutputPortDispatchers[outputPortNumber];
@@ -270,6 +270,7 @@ public final class MidiDeviceServer implements Closeable { 
            synchronized (mPortClients) {

                mPortClients.put(token, client);

            }

            return Process.myPid(); // for caller to detect same process ID

        }



        @Override