Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7fba04ca authored by Chun-Ku Lin's avatar Chun-Ku Lin
Browse files

Flag removal: clear_shortcuts_when_activity_updates_to_service 

Bug: 409608776
Test: Build succeed
Test: atest
CtsAccessibilityServiceTestCases: android.accessibilityservice.cts.AccessibilityAppUpdateTest
Flag: EXEMPT flag clean up
Change-Id: Idfed8ee5a0ad018324a84e364f1b28352f9bfc30
parent e78e39d5

services/accessibility/accessibility.aconfig

+0 −10
Original line number Diff line number Diff line
@@ -54,16 +54,6 @@ flag { 
    }

}



flag {

    name: "clear_shortcuts_when_activity_updates_to_service"

    namespace: "accessibility"

    description: "When an a11y activity is updated to an a11y service, clears the associated shortcuts so that we don't skip the AccessibilityServiceWarning."

    bug: "358092445"

    metadata {

        purpose: PURPOSE_BUGFIX

    }

}



flag {

    name: "deprecate_package_list_observer"

    namespace: "accessibility"

services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java

+9 −11
Original line number Diff line number Diff line
@@ -2600,7 +2600,6 @@ public class AccessibilityManagerService extends IAccessibilityManager.Stub 
    private boolean readInstalledAccessibilityShortcutLocked(AccessibilityUserState userState,

            List<AccessibilityShortcutInfo> parsedAccessibilityShortcutInfos) {

        if (!parsedAccessibilityShortcutInfos.equals(userState.mInstalledShortcuts)) {

            if (Flags.clearShortcutsWhenActivityUpdatesToService()) {

            List<String> componentNames = userState.mInstalledShortcuts.stream()

                    .filter(a11yActivity ->

                            !parsedAccessibilityShortcutInfos.contains(a11yActivity))
@@ -2611,7 +2610,6 @@ public class AccessibilityManagerService extends IAccessibilityManager.Stub 
                        /* enable= */ false, UserShortcutType.ALL,

                        componentNames, userState.mUserId);

            }

            }



            userState.mInstalledShortcuts.clear();

            userState.mInstalledShortcuts.addAll(parsedAccessibilityShortcutInfos);