Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ee09c4b authored by Ming-Shin Lu's avatar Ming-Shin Lu
Browse files

Fix snapshot starting window isn't apply fixed-rotation with IME visible 

As IME window will be hidden by AsyncFadeAnimationController when
receiving IME show request in IMMS side during fixed-rotation.

we could remove the previous logic from CL[1] in case snapshot starting
window surface may not apply fixed-rotation when IME snapshot visible in
the first place, since in CL[2] has already removed the disable
fixed-rotation when animating snapshot starting window with IME visible.

[1]: Idfdf129adbfbee6634d8a27aa78da1f631bd213b
[2]: Iceaedbfdb75e68e9f7fb8fd4a1bf8f35a779797e

Bug: 230733128
Test: 1. Launch a portrait app which keeps showing IME. (e.g. Chrome)
      2. Return to home be home key or swiping.
      3. Hold the device in landscape.
      4. Launch the app again.
      The app should show in landscape directly and IME will
      fade-in when it is drawn in landscape.

Change-Id: Ieb656aaa9f76d0f5dcc5487a6602e528ec771552
parent edfc3fa2

services/core/java/com/android/server/wm/StartingSurfaceController.java

+1 −3
Original line number Original line Diff line number Diff line
@@ -159,9 +159,7 @@ public class StartingSurfaceController { 
                return null;

                return null;

            }

            }

            if (topFullscreenActivity.getWindowConfiguration().getRotation()

            if (topFullscreenActivity.getWindowConfiguration().getRotation()

                    != taskSnapshot.getRotation()

                    != taskSnapshot.getRotation()) {

                    // Use normal rotation to avoid flickering of IME window in old orientation.

                    && !taskSnapshot.hasImeSurface()) {

                // The snapshot should have been checked by ActivityRecord#isSnapshotCompatible

                // The snapshot should have been checked by ActivityRecord#isSnapshotCompatible

                // that the activity will be updated to the same rotation as the snapshot. Since

                // that the activity will be updated to the same rotation as the snapshot. Since

                // the transition is not started yet, fixed rotation transform needs to be applied

                // the transition is not started yet, fixed rotation transform needs to be applied