Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7e54ef71 authored by Hung-ying Tyan's avatar Hung-ying Tyan
Browse files

Move SipService out of SystemServer to phone process. 

Companion CL: https://android-git/g/#change,70187
http://b/issue?id=2998069

Change-Id: I90923ac522ef363a4e04292f652d413c5a1526ad
parent 04a426f5

cmds/servicemanager/service_manager.c

+1 −0
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ static struct { 
    { AID_RADIO, "radio.simphonebook" },

/* TODO: remove after phone services are updated: */

    { AID_RADIO, "phone" },

    { AID_RADIO, "sip" },

    { AID_RADIO, "isms" },

    { AID_RADIO, "iphonesubinfo" },

    { AID_RADIO, "simphonebook" },

services/java/com/android/server/SystemServer.java

+0 −11
Original line number Diff line number Diff line
@@ -17,7 +17,6 @@ 
package com.android.server;



import com.android.server.am.ActivityManagerService;

import com.android.server.sip.SipService;

import com.android.internal.os.BinderInternal;

import com.android.internal.os.SamplingProfilerIntegration;
@@ -417,16 +416,6 @@ class ServerThread extends Thread { 
            } catch (Throwable e) {

                Slog.e(TAG, "Failure starting DiskStats Service", e);

            }



            try {

                SipService sipService = SipService.create(context);

                if (sipService != null) {

                    Slog.i(TAG, "Sip Service");

                    ServiceManager.addService("sip", sipService);

                }

            } catch (Throwable e) {

                Slog.e(TAG, "Failure starting SIP Service", e);

            }

        }



        // make sure the ADB_ENABLED setting value matches the secure property value

services/java/com/android/server/sip/SipService.java→voip/java/com/android/server/sip/SipService.java

+8 −5
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ import android.os.HandlerThread; 
import android.os.Looper;

import android.os.Message;

import android.os.RemoteException;

import android.os.ServiceManager;

import android.os.SystemClock;

import android.text.TextUtils;

import android.util.Log;
@@ -90,12 +91,14 @@ public final class SipService extends ISipService.Stub { 
    private ConnectivityReceiver mConnectivityReceiver;



    /**

     * Creates a {@code SipService} instance. Returns null if SIP API is not

     * supported.

     * Starts the SIP service. Do nothing if the SIP API is not supported on the

     * device.

     */

    public static SipService create(Context context) {

        return (SipManager.isApiSupported(context) ? new SipService(context)

                                                   : null);

    public static void start(Context context) {

        if (SipManager.isApiSupported(context)) {

            ServiceManager.addService("sip", new SipService(context));

            Log.i(TAG, "SIP service started");

        }

    }



    private SipService(Context context) {