Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7e336823 authored by Daniel Nishi's avatar Daniel Nishi
Browse files

Add a filter for audio apps. 

Bug: 33199077
Test: SettingsLib integ tests
Change-Id: Iad3717c78debe4d4c5edbb4337d0c79f062d93a6
parent c24bb2c4

packages/SettingsLib/src/com/android/settingslib/applications/ApplicationsState.java

+15 −0
Original line number Diff line number Diff line
@@ -1489,4 +1489,19 @@ public class ApplicationsState { 
            return mFirstFilter.filterApp(info) && mSecondFilter.filterApp(info);

        }

    }



    public static final AppFilter FILTER_AUDIO = new AppFilter() {

        @Override

        public void init() {

        }



        @Override

        public boolean filterApp(AppEntry entry) {

            boolean isMusicApp;

            synchronized(entry) {

                isMusicApp = entry.info.category == ApplicationInfo.CATEGORY_AUDIO;

            }

            return isMusicApp;

        }

    };

}

packages/SettingsLib/tests/integ/src/com/android/settingslib/applications/ApplicationsStateTest.java

+25 −6
Original line number Diff line number Diff line
@@ -29,12 +29,10 @@ import org.junit.runners.JUnit4; 


@RunWith(JUnit4.class)

public class ApplicationsStateTest {

    private ApplicationsState.AppFilter mFilter;

    private ApplicationsState.AppEntry mEntry;



    @Before

    public void setUp() {

        mFilter = ApplicationsState.FILTER_GAMES;

        mEntry = mock(ApplicationsState.AppEntry.class);

        mEntry.info = mock(ApplicationInfo.class);

    }
@@ -43,14 +41,14 @@ public class ApplicationsStateTest { 
    public void testGamesFilterAcceptsGameDeprecated() {

        mEntry.info.flags = ApplicationInfo.FLAG_IS_GAME;



        assertThat(mFilter.filterApp(mEntry)).isTrue();

        assertThat(ApplicationsState.FILTER_GAMES.filterApp(mEntry)).isTrue();

    }



    @Test

    public void testGameFilterAcceptsCategorizedGame() {

        mEntry.info.category = ApplicationInfo.CATEGORY_GAME;



        assertThat(mFilter.filterApp(mEntry)).isTrue();

        assertThat(ApplicationsState.FILTER_GAMES.filterApp(mEntry)).isTrue();

    }



    @Test
@@ -58,13 +56,34 @@ public class ApplicationsStateTest { 
        mEntry.info.flags = ApplicationInfo.FLAG_IS_GAME;

        mEntry.info.category = ApplicationInfo.CATEGORY_GAME;



        assertThat(mFilter.filterApp(mEntry)).isTrue();

        assertThat(ApplicationsState.FILTER_GAMES.filterApp(mEntry)).isTrue();

    }



    @Test

    public void testGamesFilterRejectsNotGame() {

        mEntry.info.category = ApplicationInfo.CATEGORY_UNDEFINED;



        assertThat(mFilter.filterApp(mEntry)).isFalse();

        assertThat(ApplicationsState.FILTER_GAMES.filterApp(mEntry)).isFalse();

    }



    @Test

    public void testAudioFilterAcceptsCategorizedAudio() {

        mEntry.info.category = ApplicationInfo.CATEGORY_AUDIO;



        assertThat(ApplicationsState.FILTER_AUDIO.filterApp(mEntry)).isTrue();

    }



    @Test

    public void testAudiosFilterRejectsNotAudio() {

        mEntry.info.category = ApplicationInfo.CATEGORY_GAME;



        assertThat(ApplicationsState.FILTER_AUDIO.filterApp(mEntry)).isFalse();

    }



    @Test

    public void testAudiosFilterRejectsDefaultCategory() {

        mEntry.info.category = ApplicationInfo.CATEGORY_UNDEFINED;



        assertThat(ApplicationsState.FILTER_AUDIO.filterApp(mEntry)).isFalse();

    }

}