Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7db40104 authored by Priyanka Advani (xWF)'s avatar Priyanka Advani (xWF) Committed by Android (Google) Code Review
Browse files

Revert "If wallpaper activity already exists, reorder it" 

This reverts commit fd74bb68.

Reason for revert: Droidmonitor created revert due to b/393227641. Will be verifying through ABTD before submission.

Change-Id: I8fd97516320b444b2479dd6acd3d2774030fa879
parent fd74bb68

libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DesktopTasksController.kt

+4 −9
Original line number Diff line number Diff line
@@ -1525,16 +1525,11 @@ class DesktopTasksController( 
    private fun addWallpaperActivity(displayId: Int, wct: WindowContainerTransaction) {

        logV("addWallpaperActivity")

        if (ENABLE_DESKTOP_WALLPAPER_ACTIVITY_FOR_SYSTEM_USER.isTrue()) {



            // If the wallpaper activity for this display already exists, let's reorder it to top.

            val wallpaperActivityToken = desktopWallpaperActivityTokenProvider.getToken(displayId)

            if (wallpaperActivityToken != null) {

                wct.reorder(wallpaperActivityToken, /* onTop= */ true)

                return

            }



            val intent = Intent(context, DesktopWallpaperActivity::class.java)

            if (Flags.enablePerDisplayDesktopWallpaperActivity()) {

            if (

                desktopWallpaperActivityTokenProvider.getToken(displayId) == null &&

                    Flags.enablePerDisplayDesktopWallpaperActivity()

            ) {

                intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)

                intent.addFlags(Intent.FLAG_ACTIVITY_MULTIPLE_TASK)

            }

libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/desktopmode/DesktopTasksControllerTest.kt

+2 −45
Original line number Diff line number Diff line
@@ -538,7 +538,6 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun showDesktopApps_allAppsInvisible_bringsToFront_desktopWallpaperEnabled() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)

        val task1 = setUpFreeformTask()

        val task2 = setUpFreeformTask()

        markTaskHidden(task1)
@@ -727,7 +726,6 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun showDesktopApps_appsAlreadyVisible_bringsToFront_desktopWallpaperEnabled() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)

        val task1 = setUpFreeformTask()

        val task2 = setUpFreeformTask()

        markTaskVisible(task1)
@@ -766,8 +764,7 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 


    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun showDesktopApps_someAppsInvisible_desktopWallpaperEnabled_reordersOnlyFreeformTasks() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)

    fun showDesktopApps_someAppsInvisible_reordersAll_desktopWallpaperEnabled() {

        val task1 = setUpFreeformTask()

        val task2 = setUpFreeformTask()

        markTaskHidden(task1)
@@ -784,24 +781,6 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
        wct.assertReorderAt(index = 2, task2)

    }



    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun showDesktopApps_someAppsInvisible_desktopWallpaperEnabled_reordersAll() {

        val task1 = setUpFreeformTask()

        val task2 = setUpFreeformTask()

        markTaskHidden(task1)

        markTaskVisible(task2)



        controller.showDesktopApps(DEFAULT_DISPLAY, RemoteTransition(TestRemoteTransition()))



        val wct =

            getLatestWct(type = TRANSIT_TO_FRONT, handlerClass = OneShotRemoteHandler::class.java)

        assertThat(wct.hierarchyOps).hasSize(3)

        // Expect order to be from bottom: wallpaper intent, task1, task2

        wct.assertReorderAt(index = 0, wallpaperToken)

        wct.assertReorderAt(index = 1, task1)

        wct.assertReorderAt(index = 2, task2)

    }



    @Test

    @DisableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun showDesktopApps_noActiveTasks_reorderHomeToTop_desktopWallpaperDisabled() {
@@ -817,9 +796,7 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 


    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun showDesktopApps_noActiveTasks_desktopWallpaperEnabled_addsDesktopWallpaper() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)



    fun showDesktopApps_noActiveTasks_addDesktopWallpaper_desktopWallpaperEnabled() {

        controller.showDesktopApps(DEFAULT_DISPLAY, RemoteTransition(TestRemoteTransition()))



        val wct =
@@ -827,16 +804,6 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
        wct.assertPendingIntentAt(index = 0, desktopWallpaperIntent)

    }



    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun showDesktopApps_noActiveTasks_desktopWallpaperEnabled_reordersDesktopWallpaper() {

        controller.showDesktopApps(DEFAULT_DISPLAY, RemoteTransition(TestRemoteTransition()))



        val wct =

            getLatestWct(type = TRANSIT_TO_FRONT, handlerClass = OneShotRemoteHandler::class.java)

        wct.assertReorderAt(index = 0, wallpaperToken)

    }



    @Test

    @DisableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun showDesktopApps_twoDisplays_bringsToFrontOnlyOneDisplay_desktopWallpaperDisabled() {
@@ -861,7 +828,6 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun showDesktopApps_twoDisplays_bringsToFrontOnlyOneDisplay_desktopWallpaperEnabled() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)

        taskRepository.addDesk(displayId = SECOND_DISPLAY, deskId = SECOND_DISPLAY)

        val homeTaskDefaultDisplay = setUpHomeTask(DEFAULT_DISPLAY)

        val taskDefaultDisplay = setUpFreeformTask(DEFAULT_DISPLAY)
@@ -906,7 +872,6 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun showDesktopApps_desktopWallpaperEnabled_dontReorderMinimizedTask() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)

        val homeTask = setUpHomeTask()

        val freeformTask = setUpFreeformTask()

        val minimizedTask = setUpFreeformTask()
@@ -1372,7 +1337,6 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun moveTaskToDesktop_desktopWallpaperEnabled_nonRunningTask_launchesInFreeform() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)

        val task = createTaskInfo(1)

        whenever(shellTaskOrganizer.getRunningTaskInfo(anyInt())).thenReturn(null)

        whenever(recentTasksController.findTaskInBackground(anyInt())).thenReturn(task)
@@ -1520,7 +1484,6 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun moveRunningTaskToDesktop_otherFreeformTasksBroughtToFront_desktopWallpaperEnabled() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)

        val freeformTask = setUpFreeformTask()

        val fullscreenTask = setUpFullscreenTask()

        markTaskHidden(freeformTask)
@@ -1623,7 +1586,6 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun moveRunningTaskToDesktop_desktopWallpaperEnabled_bringsTasksOverLimit_dontShowBackTask() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)

        val freeformTasks = (1..MAX_TASK_LIMIT).map { _ -> setUpFreeformTask() }

        val newTask = setUpFullscreenTask()

        val homeTask = setUpHomeTask()
@@ -2644,7 +2606,6 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun handleRequest_fullscreenTask_noTasks_enforceDesktop_freeformDisplay_returnFreeformWCT() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)

        whenever(DesktopModeStatus.enterDesktopByDefaultOnFreeformDisplay(context)).thenReturn(true)

        val tda = rootTaskDisplayAreaOrganizer.getDisplayAreaInfo(DEFAULT_DISPLAY)!!

        tda.configuration.windowConfiguration.windowingMode = WINDOWING_MODE_FREEFORM
@@ -2776,7 +2737,6 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun handleRequest_freeformTask_desktopWallpaperEnabled_freeformNotVisible_reorderedToTop() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)

        val freeformTask1 = setUpFreeformTask()

        val freeformTask2 = createFreeformTask()
@@ -2811,9 +2771,7 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun handleRequest_freeformTask_desktopWallpaperEnabled_noOtherTasks_reorderedToTop() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)

        val task = createFreeformTask()



        val result = controller.handleRequest(Binder(), createTransition(task))



        assertNotNull(result, "Should handle request")
@@ -2841,7 +2799,6 @@ class DesktopTasksControllerTest(flags: FlagsParameterization) : ShellTestCase() 
    @Test

    @EnableFlags(Flags.FLAG_ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY)

    fun handleRequest_freeformTask_dskWallpaperEnabled_freeformOnOtherDisplayOnly_reorderedToTop() {

        whenever(desktopWallpaperActivityTokenProvider.getToken()).thenReturn(null)

        val taskDefaultDisplay = createFreeformTask(displayId = DEFAULT_DISPLAY)

        // Second display task

        createFreeformTask(displayId = SECOND_DISPLAY)