Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7db2acc3 authored by Ale Nijamkin's avatar Ale Nijamkin
Browse files

[flexiglass] Move auth/bouncer work off the main thread - domain layer 

Bug: 427613105
Test: manually verified that I can still lock, unlock, and change auth method through all three
Flag: com.android.systemui.scene_container
Change-Id: I75f6d1b2b16913f03f64fe07376943b673c20f06
parent a52b085c

packages/SystemUI/src/com/android/systemui/authentication/domain/interactor/AuthenticationInteractor.kt

+2 −5
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ import com.android.systemui.authentication.shared.model.AuthenticationPatternCoo 
import com.android.systemui.authentication.shared.model.AuthenticationWipeModel

import com.android.systemui.authentication.shared.model.AuthenticationWipeModel.WipeTarget

import com.android.systemui.dagger.SysUISingleton

import com.android.systemui.dagger.qualifiers.Application

import com.android.systemui.dagger.qualifiers.Background

import com.android.systemui.log.table.TableLogBuffer

import com.android.systemui.log.table.logDiffsForTable
@@ -41,7 +40,6 @@ import javax.inject.Inject 
import kotlin.math.max

import kotlin.time.Duration

import kotlin.time.Duration.Companion.seconds

import kotlinx.coroutines.CoroutineDispatcher

import kotlinx.coroutines.CoroutineScope

import kotlinx.coroutines.delay

import kotlinx.coroutines.flow.Flow
@@ -65,8 +63,7 @@ import kotlinx.coroutines.flow.stateIn 
class AuthenticationInteractor

@Inject

constructor(

    @Application private val applicationScope: CoroutineScope,

    @Background private val backgroundDispatcher: CoroutineDispatcher,

    @Background private val applicationScope: CoroutineScope,

    private val repository: AuthenticationRepository,

    private val selectedUserInteractor: SelectedUserInteractor,

    @SceneFrameworkTableLog private val tableLogBuffer: TableLogBuffer,
@@ -342,7 +339,7 @@ constructor( 
    }



    private suspend fun initiateGarbageCollection(delay: Duration) {

        applicationScope.launch(context = backgroundDispatcher) {

        applicationScope.launch {

            delay(delay)

            System.gc()

            System.runFinalization()

packages/SystemUI/src/com/android/systemui/bouncer/domain/interactor/BouncerInteractor.kt

+2 −2
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ import com.android.systemui.classifier.FalsingClassifier 
import com.android.systemui.classifier.domain.interactor.FalsingInteractor

import com.android.systemui.common.ui.domain.interactor.ConfigurationInteractor

import com.android.systemui.dagger.SysUISingleton

import com.android.systemui.dagger.qualifiers.Application

import com.android.systemui.dagger.qualifiers.Background

import com.android.systemui.deviceentry.domain.interactor.ActiveUnlockInteractor

import com.android.systemui.deviceentry.domain.interactor.DeviceEntryFaceAuthInteractor

import com.android.systemui.log.SessionTracker
@@ -65,7 +65,7 @@ import kotlinx.coroutines.flow.map 
class BouncerInteractor

@Inject

constructor(

    @Application private val applicationScope: CoroutineScope,

    @Background private val applicationScope: CoroutineScope,

    private val repository: BouncerRepository,

    private val authenticationInteractor: AuthenticationInteractor,

    private val deviceEntryFaceAuthInteractor: DeviceEntryFaceAuthInteractor,

packages/SystemUI/src/com/android/systemui/deviceentry/domain/interactor/DeviceEntryInteractor.kt

+2 −2
Original line number Diff line number Diff line
@@ -21,7 +21,7 @@ import com.android.systemui.authentication.domain.interactor.AuthenticationInter 
import com.android.systemui.authentication.shared.model.AuthenticationMethodModel

import com.android.systemui.bouncer.domain.interactor.AlternateBouncerInteractor

import com.android.systemui.dagger.SysUISingleton

import com.android.systemui.dagger.qualifiers.Application

import com.android.systemui.dagger.qualifiers.Background

import com.android.systemui.deviceentry.data.repository.DeviceEntryRepository

import com.android.systemui.keyguard.DismissCallbackRegistry

import com.android.systemui.log.table.TableLogBuffer
@@ -59,7 +59,7 @@ import kotlinx.coroutines.launch 
class DeviceEntryInteractor

@Inject

constructor(

    @Application private val applicationScope: CoroutineScope,

    @Background private val applicationScope: CoroutineScope,

    private val repository: Lazy<DeviceEntryRepository>,

    private val authenticationInteractor: Lazy<AuthenticationInteractor>,

    private val sceneInteractor: Lazy<SceneInteractor>,

packages/SystemUI/src/com/android/systemui/keyguard/domain/interactor/StatusBarDisableFlagsInteractor.kt

+10 −16
Original line number Diff line number Diff line
@@ -32,7 +32,6 @@ import com.android.systemui.CoreStartable 
import com.android.systemui.authentication.domain.interactor.AuthenticationInteractor

import com.android.systemui.authentication.shared.model.AuthenticationMethodModel

import com.android.systemui.dagger.SysUISingleton

import com.android.systemui.dagger.qualifiers.Application

import com.android.systemui.dagger.qualifiers.Background

import com.android.systemui.deviceconfig.domain.interactor.DeviceConfigInteractor

import com.android.systemui.deviceentry.domain.interactor.DeviceEntryFaceAuthInteractor
@@ -47,13 +46,11 @@ import com.android.systemui.scene.shared.flag.SceneContainerFlag 
import com.android.systemui.shade.ShadeDisplayAware

import com.android.systemui.user.domain.interactor.SelectedUserInteractor

import javax.inject.Inject

import kotlinx.coroutines.CoroutineDispatcher

import kotlinx.coroutines.CoroutineScope

import kotlinx.coroutines.flow.combine

import kotlinx.coroutines.flow.distinctUntilChanged

import kotlinx.coroutines.flow.flowOf

import kotlinx.coroutines.flow.map

import kotlinx.coroutines.withContext



private val TAG = StatusBarDisableFlagsInteractor::class.simpleName
@@ -67,9 +64,8 @@ private val TAG = StatusBarDisableFlagsInteractor::class.simpleName 
class StatusBarDisableFlagsInteractor

@Inject

constructor(

    @Application private val scope: CoroutineScope,

    @Background private val scope: CoroutineScope,

    @ShadeDisplayAware private val context: Context,

    @Background private val backgroundDispatcher: CoroutineDispatcher,

    private val deviceEntryFaceAuthInteractor: DeviceEntryFaceAuthInteractor,

    private val statusBarService: IStatusBarService,

    private val processWrapper: ProcessWrapper,
@@ -179,7 +175,6 @@ constructor( 
                    return@collect

                }



                withContext(backgroundDispatcher) {

                try {

                    statusBarService.disableForUser(

                        flags,
@@ -194,4 +189,3 @@ constructor( 
        }

    }

}
 
}

packages/SystemUI/src/com/android/systemui/scene/domain/startable/SceneContainerStartable.kt

+10 −6
Original line number Diff line number Diff line
@@ -88,6 +88,10 @@ import com.android.systemui.util.println 
import com.android.systemui.utils.coroutines.flow.conflatedCallbackFlow

import com.google.android.msdl.data.model.MSDLToken

import com.google.android.msdl.domain.MSDLPlayer

import dagger.Lazy

import java.io.PrintWriter

import java.util.Optional

import javax.inject.Inject

import kotlinx.coroutines.CoroutineScope

import kotlinx.coroutines.channels.awaitClose

import kotlinx.coroutines.coroutineScope
@@ -106,10 +110,6 @@ import kotlinx.coroutines.flow.map 
import kotlinx.coroutines.flow.mapNotNull

import kotlinx.coroutines.flow.stateIn

import kotlinx.coroutines.launch

import dagger.Lazy

import java.io.PrintWriter

import java.util.Optional

import javax.inject.Inject



/**

 * Hooks up business logic that manipulates the state of the [SceneInteractor] for the system UI
@@ -301,9 +301,13 @@ constructor( 
                                        is ObservableTransitionState.Idle -> {

                                            if (transitionState.currentScene == Scenes.Dream) {

                                                false to "dream is showing"

                                            } else if (transitionState.currentScene != Scenes.Gone) {

                                            } else if (

                                                transitionState.currentScene != Scenes.Gone

                                            ) {

                                                true to "scene is not Gone"

                                            } else if (transitionState.currentOverlays.isNotEmpty()) {

                                            } else if (

                                                transitionState.currentOverlays.isNotEmpty()

                                            ) {

                                                true to "overlay is shown"

                                            } else {

                                                false to "scene is Gone and no overlays are shown"