Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7d8ac480 authored by Riddle Hsu's avatar Riddle Hsu Committed by Automerger Merge Worker
Browse files

Merge "[WMS][Bugfix] Catch exception when dump local window." am: 9b40b1ff 

Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2450064



Change-Id: I97a865185ec7ff6ab025c6a2c26766acaa3bcb12
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents ce08d5ec 9b40b1ff

services/core/java/com/android/server/wm/WindowManagerShellCommand.java

+18 −10
Original line number Diff line number Diff line
@@ -42,6 +42,7 @@ import android.provider.Settings; 
import android.util.DisplayMetrics;

import android.util.Pair;

import android.view.Display;

import android.view.IWindow;

import android.view.IWindowManager;

import android.view.ViewDebug;
@@ -554,6 +555,22 @@ public class WindowManagerShellCommand extends ShellCommand { 
        return 0;

    }



    private void dumpLocalWindowAsync(IWindow client, ParcelFileDescriptor pfd) {

        // Make it asynchronous to avoid writer from being blocked

        // by waiting for the buffer to be consumed in the same process.

        IoThread.getExecutor().execute(() -> {

            synchronized (mInternal.mGlobalLock) {

                try {

                    client.executeCommand(ViewDebug.REMOTE_COMMAND_DUMP_ENCODED, null, pfd);

                } catch (Exception e) {

                    // Ignore RemoteException for local call. Just print trace for other

                    // exceptions caused by RC with tolerable low possibility.

                    e.printStackTrace();

                }

            }

        });

    }



    private int runDumpVisibleWindowViews(PrintWriter pw) {

        if (!mInternal.checkCallingPermission(android.Manifest.permission.DUMP,

                "runDumpVisibleWindowViews()")) {
@@ -576,16 +593,7 @@ public class WindowManagerShellCommand extends ShellCommand { 
                            pipe = new ByteTransferPipe();

                            final ParcelFileDescriptor pfd = pipe.getWriteFd();

                            if (w.isClientLocal()) {

                                // Make it asynchronous to avoid writer from being blocked

                                // by waiting for the buffer to be consumed in the same process.

                                IoThread.getExecutor().execute(() -> {

                                    try {

                                        w.mClient.executeCommand(

                                                ViewDebug.REMOTE_COMMAND_DUMP_ENCODED, null, pfd);

                                    } catch (RemoteException e) {

                                        // Ignore for local call.

                                    }

                                });

                                dumpLocalWindowAsync(w.mClient, pfd);

                            } else {

                                w.mClient.executeCommand(

                                        ViewDebug.REMOTE_COMMAND_DUMP_ENCODED, null, pfd);