Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7d8aa4de authored by David Chen's avatar David Chen
Browse files

Small fix to addconfig in statsd. 

AddConfiguration now returns false if the incoming byte array can't
even be parsed into the expected proto format. Unfortunately, we
can't fully evaluate if this configuration is valid. Still, this
gives the caller a chance to know that the parameters it sent can't
even be parsed.

Test: Tested that statsd still builds.
Change-Id: I7ba7c64adc4bc77549d5e9133e212a4870645786
parent cb37da8b

cmds/statsd/src/StatsService.cpp

+4 −1
Original line number Diff line number Diff line
@@ -733,7 +733,10 @@ Status StatsService::addConfiguration(const String16& key, 
        string keyString = string(String8(key).string());

        ConfigKey configKey(ipc->getCallingUid(), keyString);

        StatsdConfig cfg;

        cfg.ParseFromArray(&config[0], config.size());

        if (!cfg.ParseFromArray(&config[0], config.size())) {

            *success = false;

            return Status::ok();

        }

        mConfigManager->UpdateConfig(configKey, cfg);

        mConfigManager->SetConfigReceiver(configKey, string(String8(package).string()),

                                          string(String8(cls).string()));