Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7d7ef840 authored by Jerome Gaillard's avatar Jerome Gaillard Committed by Diego Perez
Browse files

Hack to deal with android:pointerIcon in layoutlib 

android:pointerIcon is a View attribute that can be an enum or a
reference. Layoutlib cannot easily deal with the way that is handled
in the platform. As the property would not have any impact on the
result in layoutlib, that property is bypassed.

Test: Main.testAllWidgets
Change-Id: I38c6c6df45c1836d44b4f80245a453fb432ea251
parent 6782b0e7

tools/layoutlib/bridge/src/android/view/PointerIcon_Delegate.java

0 → 100644
+33 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2016 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



package android.view;



import com.android.tools.layoutlib.annotations.LayoutlibDelegate;



import android.content.Context;

import android.content.res.Resources;



public class PointerIcon_Delegate {



    @LayoutlibDelegate

    /*package*/ static void loadResource(PointerIcon icon, Context context, Resources resources,

            int resourceId) {

        // HACK: This bypasses the problem of having an enum resolved as a resourceId.

        // PointerIcon would not be displayed by layoutlib anyway, so we always return the null

        // icon.

    }

}

tools/layoutlib/bridge/tests/res/testApp/MyApplication/src/main/res/layout/allwidgets.xml

+2 −1
Original line number Diff line number Diff line
@@ -28,7 +28,8 @@ 
        android:layout_alignParentStart="true"

        android:layout_below="@id/frameLayout"

        android:text="Large Text"

        android:textAppearance="?android:attr/textAppearanceLarge" />

        android:textAppearance="?android:attr/textAppearanceLarge"

        android:pointerIcon="hand" />



    <TextView

        android:id="@id/textView3"

tools/layoutlib/create/src/com/android/tools/layoutlib/create/CreateInfo.java

+1 −0
Original line number Diff line number Diff line
@@ -232,6 +232,7 @@ public final class CreateInfo implements ICreateInfo { 
        "android.view.RenderNode#nSetScaleY",

        "android.view.RenderNode#nGetScaleY",

        "android.view.RenderNode#nIsPivotExplicitlySet",

        "android.view.PointerIcon#loadResource",

        "android.view.ViewGroup#drawChild",

        "com.android.internal.view.menu.MenuBuilder#createNewMenuItem",

        "com.android.internal.util.XmlUtils#convertValueToInt",