Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7d79c953 authored by Linus Tufvesson's avatar Linus Tufvesson Committed by Android (Google) Code Review
Browse files

Revert "HACK: allow apps with pre-release SDK" 

This reverts commit d5d85c3c.

Reason for revert: Remove hack that allowed apps compiled against the pre-release SDK

Change-Id: If6a6e9d9d9a96df3875362359e4b786e68d14714
parent d5d85c3c

core/java/android/content/pm/PackageParser.java

+0 −18
Original line number Diff line number Diff line
@@ -2628,15 +2628,6 @@ public class PackageParser { 
            return Build.VERSION_CODES.CUR_DEVELOPMENT;

        }



        // STOPSHIP: hack for the pre-release SDK

        if (platformSdkCodenames.length == 0

                && Build.VERSION.KNOWN_CODENAMES.stream().max(String::compareTo).orElse("").equals(

                targetCode)) {

            Slog.w(TAG, "Package requires development platform " + targetCode

                    + ", returning current version " + Build.VERSION.SDK_INT);

            return Build.VERSION.SDK_INT;

        }



        // Otherwise, we're looking at an incompatible pre-release SDK.

        if (platformSdkCodenames.length > 0) {

            outError[0] = "Requires development platform " + targetCode
@@ -2708,15 +2699,6 @@ public class PackageParser { 
            return Build.VERSION_CODES.CUR_DEVELOPMENT;

        }



        // STOPSHIP: hack for the pre-release SDK

        if (platformSdkCodenames.length == 0

                && Build.VERSION.KNOWN_CODENAMES.stream().max(String::compareTo).orElse("").equals(

                minCode)) {

            Slog.w(TAG, "Package requires min development platform " + minCode

                    + ", returning current version " + Build.VERSION.SDK_INT);

            return Build.VERSION.SDK_INT;

        }



        // Otherwise, we're looking at an incompatible pre-release SDK.

        if (platformSdkCodenames.length > 0) {

            outError[0] = "Requires development platform " + minCode

core/java/android/content/pm/parsing/FrameworkParsingPackageUtils.java

+8 −25
Original line number Diff line number Diff line
@@ -316,15 +316,6 @@ public class FrameworkParsingPackageUtils { 
            return input.success(Build.VERSION_CODES.CUR_DEVELOPMENT);

        }



        // STOPSHIP: hack for the pre-release SDK

        if (platformSdkCodenames.length == 0

                && Build.VERSION.KNOWN_CODENAMES.stream().max(String::compareTo).orElse("").equals(

                        minCode)) {

            Slog.w(TAG, "Parsed package requires min development platform " + minCode

                    + ", returning current version " + Build.VERSION.SDK_INT);

            return input.success(Build.VERSION.SDK_INT);

        }



        // Otherwise, we're looking at an incompatible pre-release SDK.

        if (platformSdkCodenames.length > 0) {

            return input.error(PackageManager.INSTALL_FAILED_OLDER_SDK,
@@ -407,27 +398,19 @@ public class FrameworkParsingPackageUtils { 
            return input.success(targetVers);

        }



        // If it's a pre-release SDK and the codename matches this platform, it

        // definitely targets this SDK.

        if (matchTargetCode(platformSdkCodenames, targetCode)) {

            return input.success(Build.VERSION_CODES.CUR_DEVELOPMENT);

        }



        // STOPSHIP: hack for the pre-release SDK

        if (platformSdkCodenames.length == 0

                && Build.VERSION.KNOWN_CODENAMES.stream().max(String::compareTo).orElse("").equals(

                        targetCode)) {

            Slog.w(TAG, "Parsed package requires development platform " + targetCode

                    + ", returning current version " + Build.VERSION.SDK_INT);

            return input.success(Build.VERSION.SDK_INT);

        }



        try {

            if (allowUnknownCodenames && UnboundedSdkLevel.isAtMost(targetCode)) {

                return input.success(Build.VERSION_CODES.CUR_DEVELOPMENT);

            }

        } catch (IllegalArgumentException e) {

            return input.error(PackageManager.INSTALL_FAILED_OLDER_SDK, "Bad package SDK");

            // isAtMost() throws it when encountering an older SDK codename

            return input.error(PackageManager.INSTALL_FAILED_OLDER_SDK, e.getMessage());

        }



        // If it's a pre-release SDK and the codename matches this platform, it

        // definitely targets this SDK.

        if (matchTargetCode(platformSdkCodenames, targetCode)) {

            return input.success(Build.VERSION_CODES.CUR_DEVELOPMENT);

        }



        // Otherwise, we're looking at an incompatible pre-release SDK.

services/tests/servicestests/src/com/android/server/systemconfig/SystemConfigTest.java

+2 −2
Original line number Diff line number Diff line
@@ -452,14 +452,14 @@ public class SystemConfigTest { 
                        + "    <library \n"

                        + "        name=\"foo\"\n"

                        + "        file=\"" + mFooJar + "\"\n"

                        + "        on-bootclasspath-before=\"A\"\n"

                        + "        on-bootclasspath-before=\"Q\"\n"

                        + "        on-bootclasspath-since=\"W\"\n"

                        + "     />\n\n"

                        + " </permissions>";

        parseSharedLibraries(contents);

        assertFooIsOnlySharedLibrary();

        SystemConfig.SharedLibraryEntry entry = mSysConfig.getSharedLibraries().get("foo");

        assertThat(entry.onBootclasspathBefore).isEqualTo("A");

        assertThat(entry.onBootclasspathBefore).isEqualTo("Q");

        assertThat(entry.onBootclasspathSince).isEqualTo("W");

    }