Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cdc3bf9 authored by Jeff Sharkey's avatar Jeff Sharkey
Browse files

Upgrade AndroidFrameworkBinderIdentity to fatal. 

We've fixed all outstanding examples of malformed code, so we're
ready to upgrade this Error Prone detector to break the build to
ensure that all future code follows best-practices.

Bug: 155703208
Test: make
Change-Id: I617b8e7a8f96a4299ed0144bd915b87920f1af87
parent b93712f6

Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -601,6 +601,7 @@ java_library { 
    ],

    errorprone: {

        javacflags: [

            "-Xep:AndroidFrameworkBinderIdentity:ERROR",

            "-Xep:AndroidFrameworkCompatChange:ERROR",

            "-Xep:AndroidFrameworkUid:ERROR",

        ],

errorprone/tests/java/com/google/errorprone/bugpatterns/android/BinderIdentityCheckerTest.java

+1 −1
Original line number Diff line number Diff line
@@ -89,7 +89,7 @@ public class BinderIdentityCheckerTest { 
                        "  }",

                        "  void noFinal() {",

                        "    // BUG: Diagnostic contains:",

                        "    final long token = Binder.clearCallingIdentity();",

                        "    long token = Binder.clearCallingIdentity();",

                        "    try {",

                        "      FooService.class.toString();",

                        "    } finally {",

services/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -5,6 +5,7 @@ java_defaults { 
    ],

    errorprone: {

        javacflags: [

            "-Xep:AndroidFrameworkBinderIdentity:ERROR",

            "-Xep:AndroidFrameworkCompatChange:ERROR",

            "-Xep:AndroidFrameworkUid:ERROR",

        ],