Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c81c3aa authored by Richard Uhler's avatar Richard Uhler
Browse files

Log RemoteExceptions from RollbackManager. 

It is entirely possible to get a RemoteException from RollbackManager,
even if it is in the same process. Remove the comments that suggest
otherwise and log the failures instead.

Bug: 136461171
Test: atest CtsRollbackManagerHostTestCases:com.android.cts.rollback.host.RollbackManagerHostTest#testApexAndApkStagedRollback
Change-Id: I8e7936ada5c19b53be4e3e8dc5ad7165d216d8ac
parent b2de76fe

services/core/java/com/android/server/pm/StagingManager.java

+4 −2
Original line number Diff line number Diff line
@@ -443,7 +443,8 @@ public class StagingManager { 
            try {

                rm.notifyStagedApkSession(originalSession.sessionId, apkSession.sessionId);

            } catch (RemoteException re) {

                // Cannot happen, the rollback manager is in the same process.

                Slog.e(TAG, "Failed to notifyStagedApkSession for session: "

                        + originalSession.sessionId, re);

            }

        }
@@ -856,7 +857,8 @@ public class StagingManager { 
                                + session.sessionId);

                    }

                } catch (RemoteException re) {

                    // Cannot happen, the rollback manager is in the same process.

                    Slog.e(TAG, "Failed to notifyStagedSession for session: "

                            + session.sessionId, re);

                }

            }