Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c1786be authored by Matt Buckley's avatar Matt Buckley
Browse files

Create HintSessionWrapper in RT right after CanvasContext 

Move the construction of the HintSessionWrapper to RT right after the
creation of the CanvasContext to ensure enough time is provided to
not block the critical path in most cases.

Bug: 263755904
Test: manual
Change-Id: Ibab98b811de9056c51092286398d5c41c4d1d86b
Merged-In: I1a67b163acd9c41156d9b9e14e974c67b6ba6ed5
parent 4514e31e

libs/hwui/renderthread/DrawFrameTask.cpp

+5 −0
Original line number Diff line number Diff line
@@ -278,6 +278,11 @@ void DrawFrameTask::unblockUiThread() { 
    mSignal.signal();

}



void DrawFrameTask::createHintSession(pid_t uiThreadId, pid_t renderThreadId) {

    if (mHintSessionWrapper) return;

    mHintSessionWrapper.emplace(uiThreadId, renderThreadId);

}



DrawFrameTask::HintSessionWrapper::HintSessionWrapper(int32_t uiThreadId, int32_t renderThreadId) {

    if (!Properties::useHintManager) return;

    if (uiThreadId < 0 || renderThreadId < 0) return;

libs/hwui/renderthread/DrawFrameTask.h

+2 −0
Original line number Diff line number Diff line
@@ -90,6 +90,8 @@ public: 


    void forceDrawNextFrame() { mForceDrawFrame = true; }



    void createHintSession(pid_t uiThreadId, pid_t renderThreadId);



private:

    class HintSessionWrapper {

    public:

libs/hwui/renderthread/RenderProxy.cpp

+11 −4
Original line number Diff line number Diff line
@@ -38,11 +38,18 @@ namespace renderthread { 
RenderProxy::RenderProxy(bool translucent, RenderNode* rootRenderNode,

                         IContextFactory* contextFactory)

        : mRenderThread(RenderThread::getInstance()), mContext(nullptr) {

    mContext = mRenderThread.queue().runSync([&]() -> CanvasContext* {

        return CanvasContext::create(mRenderThread, translucent, rootRenderNode, contextFactory);

    pid_t uiThreadId = pthread_gettid_np(pthread_self());

    pid_t renderThreadId = getRenderThreadTid();

    mContext = mRenderThread.queue().runSync([=, this]() -> CanvasContext* {

        CanvasContext* context =

                CanvasContext::create(mRenderThread, translucent, rootRenderNode, contextFactory);

        if (context != nullptr) {

            mRenderThread.queue().post(

                    [=] { mDrawFrameTask.createHintSession(uiThreadId, renderThreadId); });

        }

        return context;

    });

    mDrawFrameTask.setContext(&mRenderThread, mContext, rootRenderNode,

                              pthread_gettid_np(pthread_self()), getRenderThreadTid());

    mDrawFrameTask.setContext(&mRenderThread, mContext, rootRenderNode, uiThreadId, renderThreadId);

}



RenderProxy::~RenderProxy() {