Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c01afdd authored by Phil Weaver's avatar Phil Weaver
Browse files

Remove abstract from AccessibilityService methods 

Two methods on AccessibilityService were declared abstract, but
there doesn't seem to be a good reason for them to be abstract, as
it's possible to write an accessibility service that doesn't do
anything useful with the methods. Removing the abstract qualifier
to reduce boilerplate for service developers.

Bug: 31705365
Test: Trivial change, so I just verified that it builds.
Change-Id: I2af39848c8ab343d562361fdc1c3f8ca3ecb5f00
parent eb0a2901

api/current.txt

+2 −2
Original line number Diff line number Diff line
@@ -2722,10 +2722,10 @@ package android.accessibilityservice { 
    method public final android.accessibilityservice.AccessibilityServiceInfo getServiceInfo();

    method public final android.accessibilityservice.AccessibilityService.SoftKeyboardController getSoftKeyboardController();

    method public java.util.List<android.view.accessibility.AccessibilityWindowInfo> getWindows();

    method public abstract void onAccessibilityEvent(android.view.accessibility.AccessibilityEvent);

    method public void onAccessibilityEvent(android.view.accessibility.AccessibilityEvent);

    method public final android.os.IBinder onBind(android.content.Intent);

    method protected boolean onGesture(int);

    method public abstract void onInterrupt();

    method public void onInterrupt();

    method protected boolean onKeyEvent(android.view.KeyEvent);

    method protected void onServiceConnected();

    method public final boolean performGlobalAction(int);

api/system-current.txt

+2 −2
Original line number Diff line number Diff line
@@ -2842,10 +2842,10 @@ package android.accessibilityservice { 
    method public final android.accessibilityservice.AccessibilityServiceInfo getServiceInfo();

    method public final android.accessibilityservice.AccessibilityService.SoftKeyboardController getSoftKeyboardController();

    method public java.util.List<android.view.accessibility.AccessibilityWindowInfo> getWindows();

    method public abstract void onAccessibilityEvent(android.view.accessibility.AccessibilityEvent);

    method public void onAccessibilityEvent(android.view.accessibility.AccessibilityEvent);

    method public final android.os.IBinder onBind(android.content.Intent);

    method protected boolean onGesture(int);

    method public abstract void onInterrupt();

    method public void onInterrupt();

    method protected boolean onKeyEvent(android.view.KeyEvent);

    method protected void onServiceConnected();

    method public final boolean performGlobalAction(int);

api/test-current.txt

+2 −2
Original line number Diff line number Diff line
@@ -2722,10 +2722,10 @@ package android.accessibilityservice { 
    method public final android.accessibilityservice.AccessibilityServiceInfo getServiceInfo();

    method public final android.accessibilityservice.AccessibilityService.SoftKeyboardController getSoftKeyboardController();

    method public java.util.List<android.view.accessibility.AccessibilityWindowInfo> getWindows();

    method public abstract void onAccessibilityEvent(android.view.accessibility.AccessibilityEvent);

    method public void onAccessibilityEvent(android.view.accessibility.AccessibilityEvent);

    method public final android.os.IBinder onBind(android.content.Intent);

    method protected boolean onGesture(int);

    method public abstract void onInterrupt();

    method public void onInterrupt();

    method protected boolean onKeyEvent(android.view.KeyEvent);

    method protected void onServiceConnected();

    method public final boolean performGlobalAction(int);

core/java/android/accessibilityservice/AccessibilityService.java

+2 −2
Original line number Diff line number Diff line
@@ -421,12 +421,12 @@ public abstract class AccessibilityService extends Service { 
     * this method returns. Services wishing to use the event after this method returns should

     * make a copy.

     */

    public abstract void onAccessibilityEvent(AccessibilityEvent event);

    public void onAccessibilityEvent(AccessibilityEvent event) {}



    /**

     * Callback for interrupting the accessibility feedback.

     */

    public abstract void onInterrupt();

    public void onInterrupt() {}



    /**

     * Dispatches service connection to internal components first, then the