Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7bce9031 authored by lifr's avatar lifr Committed by Frank Li
Browse files

Define rcode=12~15 (UNASSIGNED) in rcode enum type 

RCODE   Name
11      NS_R_MAX
12      NS_R_UNASSIGNED12
13      NS_R_UNASSIGNED13
14      NS_R_UNASSIGNED14
15      NS_R_UNASSIGNED15
16      NS_R_BADVERS

According the stats data of Dns Resolver module,
Some DNS Servers might return undefined code to devices.
Without the enum definition, that would be noise for our dashboard

Bug: 150194702
Test: Manual test with statsd_testdrive
Change-Id: I178164f37b70d0ce86dfb7e37e01b663abbf82f2
parent 76874777

core/proto/android/stats/dnsresolver/dns_resolver.proto

+7 −0
Original line number Diff line number Diff line
@@ -62,6 +62,13 @@ enum NsRcode { 
    NS_R_NOTAUTH = 9;   // Not authoritative for zone

    NS_R_NOTZONE = 10;  // Zone of record different from zone section

    NS_R_MAX = 11;

    // Define rcode=12~15(UNASSIGNED) in rcode enum type.

    // Some DNS Servers might return undefined code to devices.

    // Without the enum definition, that would be noise for our dashboard.

    NS_R_UNASSIGNED12 = 12; // Unassigned

    NS_R_UNASSIGNED13 = 13; // Unassigned

    NS_R_UNASSIGNED14 = 14; // Unassigned

    NS_R_UNASSIGNED15 = 15; // Unassigned

    // The following are EDNS extended rcodes

    NS_R_BADVERS = 16;

    // The following are TSIG errors