Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7bc3744c authored by Rohan Shah's avatar Rohan Shah
Browse files

[QS] Update mobile tile secondary text 

Since the mobile data string is required for the content description,
adding a new string for the short version and updating the footer impl
and icon setup logic to reference the content description instead.

Test: Manually, via string check in QS
Bug: 77693344
Change-Id: I794500bcd445f98d69c096f6bf2f3b7d147c2780
parent ee7bc05a

packages/SystemUI/res/values/strings.xml

+4 −1
Original line number Diff line number Diff line
@@ -405,7 +405,10 @@ 
    <string name="accessibility_cell_data_on">Mobile Data On</string>



    <!-- Content description of the cell data being disabled. [CHAR LIMIT=NONE] -->

    <string name="cell_data_off">Mobile data off</string>

    <string name="cell_data_off_content_description">Mobile data off</string>



    <!-- Content description of the cell data being disabled but shortened. [CHAR LIMIT=20] -->

    <string name="cell_data_off">Off</string>



    <!-- Content description of the bluetooth tethering icon for accessibility (not shown on the screen). [CHAR LIMIT=NONE] -->

    <string name="accessibility_bluetooth_tether">Bluetooth tethering.</string>

packages/SystemUI/src/com/android/systemui/qs/QSFooterImpl.java

+1 −1
Original line number Diff line number Diff line
@@ -393,7 +393,7 @@ public class QSFooterImpl extends FrameLayout implements QSFooter, 
            if (TextUtils.equals(mInfo.typeContentDescription,

                    mContext.getString(R.string.data_connection_no_internet))

                || TextUtils.equals(mInfo.typeContentDescription,

                    mContext.getString(R.string.cell_data_off))) {

                    mContext.getString(R.string.cell_data_off_content_description))) {

                contentDescription.append(mInfo.typeContentDescription);

            }

            mMobileSignal.setContentDescription(contentDescription);

packages/SystemUI/src/com/android/systemui/qs/tiles/CellularTile.java

+12 −1
Original line number Diff line number Diff line
@@ -194,7 +194,18 @@ public class CellularTile extends QSTileImpl<SignalState> { 
            state.state = Tile.STATE_INACTIVE;

            state.secondaryLabel = r.getString(R.string.cell_data_off);

        }

        state.contentDescription = state.label + ", " + state.secondaryLabel;





        // TODO(b/77881974): Instead of switching out the description via a string check for

        // we need to have two strings provided by the MobileIconGroup.

        final CharSequence contentDescriptionSuffix;

        if (state.state == Tile.STATE_INACTIVE) {

            contentDescriptionSuffix = r.getString(R.string.cell_data_off_content_description);

        } else {

            contentDescriptionSuffix = state.secondaryLabel;

        }



        state.contentDescription = state.label + ", " + contentDescriptionSuffix;

    }



    private CharSequence getMobileDataDescription(CallbackInfo cb) {

packages/SystemUI/src/com/android/systemui/statusbar/policy/TelephonyIcons.java

+1 −1
Original line number Diff line number Diff line
@@ -208,7 +208,7 @@ class TelephonyIcons { 
            0,

            0,

            AccessibilityContentDescriptions.PHONE_SIGNAL_STRENGTH[0],

            R.string.cell_data_off,

            R.string.cell_data_off_content_description,

            0,

            false);

}