Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7bc31dc1 authored by Inseob Kim's avatar Inseob Kim
Browse files

Schematize vold system properties 

Properties accessed across partitions are now schematized and will
become APIs to make explicit interfaces among partitions.

Bug: 117924132
Test: m -j
Change-Id: I8e04f643197b6c8a60cc38c6979e41c5de3469f5
Merged-In: I8e04f643197b6c8a60cc38c6979e41c5de3469f5
parent c02d53b0

Android.bp

+2 −0
Original line number Diff line number Diff line
@@ -619,6 +619,8 @@ java_defaults { 
        "core/java/com/android/server/DropboxLogTags.logtags",

        "core/java/org/chromium/arc/EventLogTags.logtags",



        ":platform-properties",



        ":framework-statslog-gen",

    ],

core/java/android/os/storage/StorageManager.java

+3 −2
Original line number Diff line number Diff line
@@ -52,6 +52,7 @@ import android.os.ServiceManager; 
import android.os.ServiceManager.ServiceNotFoundException;

import android.os.SystemProperties;

import android.provider.Settings;

import android.sysprop.VoldProperties;

import android.system.ErrnoException;

import android.system.Os;

import android.system.OsConstants;
@@ -1465,7 +1466,7 @@ public class StorageManager { 
     * framework, so no service needs to check for changes during their lifespan

     */

    public static boolean isBlockEncrypting() {

        final String state = SystemProperties.get("vold.encrypt_progress", "");

        final String state = VoldProperties.encrypt_progress().orElse("");

        return !"".equalsIgnoreCase(state);

    }
@@ -1481,7 +1482,7 @@ public class StorageManager { 
     * framework, so no service needs to check for changes during their lifespan

     */

    public static boolean inCryptKeeperBounce() {

        final String status = SystemProperties.get("vold.decrypt");

        final String status = VoldProperties.decrypt().orElse("");

        return "trigger_restart_min_framework".equals(status);

    }

packages/SystemUI/src/com/android/systemui/statusbar/policy/EncryptionHelper.java

+2 −2
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ 


package com.android.systemui.statusbar.policy;



import android.os.SystemProperties;

import android.sysprop.VoldProperties;



/**

 * Helper for determining whether the phone is decrypted yet.
@@ -26,7 +26,7 @@ public class EncryptionHelper { 
    public static final boolean IS_DATA_ENCRYPTED = isDataEncrypted();



    private static boolean isDataEncrypted() {

        String voldState = SystemProperties.get("vold.decrypt");

        String voldState = VoldProperties.decrypt().orElse("");

        return "1".equals(voldState) || "trigger_restart_min_framework".equals(voldState);

    }

}

services/core/java/com/android/server/StorageManagerService.java

+2 −1
Original line number Diff line number Diff line
@@ -99,6 +99,7 @@ import android.os.storage.VolumeInfo; 
import android.os.storage.VolumeRecord;

import android.provider.MediaStore;

import android.provider.Settings;

import android.sysprop.VoldProperties;

import android.text.TextUtils;

import android.text.format.DateUtils;

import android.util.ArrayMap;
@@ -973,7 +974,7 @@ class StorageManagerService extends IStorageManager.Stub 


        // On an encrypted device we can't see system properties yet, so pull

        // the system locale out of the mount service.

        if ("".equals(SystemProperties.get("vold.encrypt_progress"))) {

        if ("".equals(VoldProperties.encrypt_progress().orElse(""))) {

            copyLocaleFromMountService();

        }

    }

services/core/java/com/android/server/am/ActivityManagerService.java

+3 −2
Original line number Diff line number Diff line
@@ -364,6 +364,7 @@ import android.provider.Downloads; 
import android.provider.Settings;

import android.service.voice.IVoiceInteractionSession;

import android.service.voice.VoiceInteractionManagerInternal;

import android.sysprop.VoldProperties;

import android.telecom.TelecomManager;

import android.text.TextUtils;

import android.text.format.DateUtils;
@@ -7970,8 +7971,8 @@ public class ActivityManagerService extends IActivityManager.Stub 
            SystemProperties.set("sys.boot_completed", "1");















            // And trigger dev.bootcomplete if we are not showing encryption progress













            if (!"trigger_restart_min_framework".equals(SystemProperties.get("vold.decrypt"))













                    || "".equals(SystemProperties.get("vold.encrypt_progress"))) {













            if (!"trigger_restart_min_framework".equals(VoldProperties.decrypt().orElse(""))













                    || "".equals(VoldProperties.encrypt_progress().orElse(""))){















                SystemProperties.set("dev.bootcomplete", "1");















            }















            mUserController.sendBootCompleted(