Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7bc2202d authored by Brad Fitzpatrick's avatar Brad Fitzpatrick
Browse files

Lazily allocate the mBounds Rect in Drawable. 

For background, see:
http://kohlerm.blogspot.com/2009/04/analyzing-memory-usage-off-your-android.html

Thanks, Markus!
parent 284e9b27

graphics/java/android/graphics/drawable/Drawable.java

+8 −2
Original line number Diff line number Diff line
@@ -97,10 +97,12 @@ import android.util.TypedValue; 
 */

public abstract class Drawable {



    private static final Rect ZERO_BOUNDS_RECT = new Rect();



    private int[] mStateSet = StateSet.WILD_CARD;

    private int mLevel = 0;

    private int mChangingConfigurations = 0;

    private Rect mBounds = new Rect();

    private Rect mBounds = ZERO_BOUNDS_RECT;  // lazily becomes a new Rect()

    /*package*/ Callback mCallback = null;

    private boolean mVisible = true;
@@ -119,6 +121,10 @@ public abstract class Drawable { 
    public void setBounds(int left, int top, int right, int bottom) {

        Rect oldBounds = mBounds;



        if (oldBounds == ZERO_BOUNDS_RECT) {

            oldBounds = mBounds = new Rect();

        }



        if (oldBounds.left != left || oldBounds.top != top ||

                oldBounds.right != right || oldBounds.bottom != bottom) {

            mBounds.set(left, top, right, bottom);