Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b645903 authored by Yurii Zubrytskyi's avatar Yurii Zubrytskyi
Browse files

[aapt2] fix a typo in an error for duplicate overlayable 

+ simplify a piece of code nearby

Fixes: b/352125289
Test: builds
Flag: EXEMPT typo fix in a string
Change-Id: I3906e688ce7f7b95cbe51cca7b8a72d75b48fa3d
parent 8fcda25c

tools/aapt2/format/binary/TableFlattener.cpp

+2 −8
Original line number Diff line number Diff line
@@ -307,7 +307,7 @@ class PackageFlattener { 
          if (!(chunk.source == item.overlayable->source)) {

            // The name of an overlayable set of resources must be unique

            context_->GetDiagnostics()->Error(android::DiagMessage(item.overlayable->source)

                                              << "duplicate overlayable name"

                                              << "duplicate overlayable name '"

                                              << item.overlayable->name << "'");

            context_->GetDiagnostics()->Error(android::DiagMessage(chunk.source)

                                              << "previous declaration here");
@@ -325,13 +325,7 @@ class PackageFlattener { 
          return false;

        }



        auto policy = overlayable_chunk->policy_ids.find(item.policies);

        if (policy != overlayable_chunk->policy_ids.end()) {

          policy->second.insert(id);

        } else {

          overlayable_chunk->policy_ids.insert(

              std::make_pair(item.policies, std::set<ResourceId>{id}));

        }

        overlayable_chunk->policy_ids[item.policies].insert(id);

      }

    }