Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b596299 authored by Michal Brzezinski's avatar Michal Brzezinski
Browse files

Fixing QS not visible when opening split shade with adb command 

The command stopped working because we stopped relying on implicitly expanded state and now we want to explicitly change state to qsExpanded when shade is expanded. That will be done automatically if LockscreenShadeTransitionController animates QS.

Fixes: 255445410
Test: run "adb shell cmd accessibility call-system-action 5" in split lockscreen and see QS appearing
Change-Id: I9b80cfac476e0089300639e03efcc669ca99a22a
parent f382a4ce

packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java

+1 −1
Original line number Diff line number Diff line
@@ -2020,7 +2020,7 @@ public final class NotificationPanelViewController { 
            // case but currently motion in portrait looks worse than when using flingSettings.

            // TODO: make below function transitioning smoothly also in portrait with null target

            mLockscreenShadeTransitionController.goToLockedShade(

                    /* expandedView= */null, /* needsQSAnimation= */false);

                    /* expandedView= */null, /* needsQSAnimation= */true);

        } else if (isFullyCollapsed()) {

            expand(true /* animate */);

        } else {

packages/SystemUI/tests/src/com/android/systemui/shade/NotificationPanelViewControllerTest.java

+1 −1
Original line number Diff line number Diff line
@@ -1285,7 +1285,7 @@ public class NotificationPanelViewControllerTest extends SysuiTestCase { 
        mNotificationPanelViewController.expandWithQs();



        verify(mLockscreenShadeTransitionController).goToLockedShade(

                /* expandedView= */null, /* needsQSAnimation= */false);

                /* expandedView= */null, /* needsQSAnimation= */true);

    }



    @Test