Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b0d02cd authored by Henry Fang's avatar Henry Fang Committed by Android (Google) Code Review
Browse files

Merge "Tuner JNI: Correct memcpy of C2DataIdInfo"

parents 22e00e02 df828043

media/jni/android_media_tv_Tuner.cpp

+3 −2
Original line number Original line Diff line number Diff line
@@ -291,8 +291,9 @@ MQ& Dvr::getDvrMQ() { 
C2DataIdInfo::C2DataIdInfo(uint32_t index, uint64_t value) : C2Param(kParamSize, index) {

C2DataIdInfo::C2DataIdInfo(uint32_t index, uint64_t value) : C2Param(kParamSize, index) {

    CHECK(isGlobal());

    CHECK(isGlobal());

    CHECK_EQ(C2Param::INFO, kind());

    CHECK_EQ(C2Param::INFO, kind());

    DummyInfo info{value};

    mInfo = StubInfo(value);

    memcpy(this + 1, static_cast<C2Param *>(&info) + 1, kParamSize - sizeof(C2Param));

    memcpy(static_cast<C2Param *>(this) + 1, static_cast<C2Param *>(&mInfo) + 1,

            kParamSize - sizeof(C2Param));

}

}





/////////////// MediaEvent ///////////////////////

/////////////// MediaEvent ///////////////////////

media/jni/android_media_tv_Tuner.h

+3 −2
Original line number Original line Diff line number Diff line
@@ -250,8 +250,9 @@ class C2DataIdInfo : public C2Param { 
public:

public:

    C2DataIdInfo(uint32_t index, uint64_t value);

    C2DataIdInfo(uint32_t index, uint64_t value);

private:

private:

    typedef C2GlobalParam<C2Info, C2Int64Value, 0> DummyInfo;

    typedef C2GlobalParam<C2Info, C2Int64Value, 0> StubInfo;

    static const size_t kParamSize = sizeof(DummyInfo);

    StubInfo mInfo;

    static const size_t kParamSize = sizeof(StubInfo);

};

};





}  // namespace android

}  // namespace android